[ovs-git] [openvswitch/ovs] 5905b2: ovn-controller: Change duplicate flows trace from ...

GitHub noreply at github.com
Tue Jan 9 19:32:54 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 5905b28f1abff1a295ea37654d887154b0dc2bc0
      https://github.com/openvswitch/ovs/commit/5905b28f1abff1a295ea37654d887154b0dc2bc0
  Author: Daniel Alvarez <dalvarez at redhat.com>
  Date:   2018-01-09 (Tue, 09 Jan 2018)

  Changed paths:
    M ovn/controller/ofctrl.c

  Log Message:
  -----------
  ovn-controller: Change duplicate flows trace from INFO to DBG

When ovn-controller detects that a flow is duplicated, it will print an
INFO trace. Even though it's rate limited, this patch is changing the
trace level back to DEBUG to reduce noise.

Background: in our effort to ensure consistency across objects in
Neutron and OVN databases we find some special cases like security group
rules which match OVN ACLs but not in 1:1 relationship. Until now, two
identical security group rules beloning each to a different security
group would generate a single ACL in NB database. With this behavior,
there's no way to map the ACL in OVN to the corresponding Neutron
object.

By implementing [0] we're trying to ensure this mapping so we make use
of the external_ids column of every table for this purpose. It may
happen that we'll have two identical ACLs but each referencing a
different Neutron object in their external_ids field. However, this will
make ovn-controller to drop those duplicated flows and log a (rate
controlled) INFO trace. In order to reduce this noise, this patch
changes it to DBG.

See also the ovs-dev discussion at [1].

[0] https://docs.openstack.org/networking-ovn/latest/contributor/design/database_consistency.html
[1] https://mail.openvswitch.org/pipermail/ovs-dev/2018-January/342652.html.

Signed-off-by: Daniel Alvarez <dalvarez at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list