[ovs-git] [openvswitch/ovs] 22dcb5: netdev-linux: do not send packets to down tap ifac...

GitHub noreply at github.com
Mon Jan 22 18:51:21 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 22dcb53449d9e7f6c949b46a5331c47653559369
      https://github.com/openvswitch/ovs/commit/22dcb53449d9e7f6c949b46a5331c47653559369
  Author: Flavio Leitner <fbl at sysclose.org>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M NEWS
    M lib/netdev-linux.c
    M vswitchd/vswitch.xml

  Log Message:
  -----------
  netdev-linux: do not send packets to down tap ifaces.

Today OVS pushes packets to the TAP interface ignoring its
current state. That works because the kernel will return -EIO
when it's not UP and OVS will just ignore that as it is not
an OVS issue.

However, it causes a huge impact when broadcasts happen when
using userspace datapath accelerated with DPDK (e.g.: action
NORMAL).  This patch improves the situation by checking the
TAP's interface state before issueing any syscall.

However, there might be use-cases moving interfaces to other
networking namespaces and in that case, OVS can't retrieve
the iface state (sets it to DOWN). That would stop the traffic
breaking the use-case. This patch relies on netlink notifications
to find out if the device is local or not. When it's local, the
device state is checked otherwise it will behave as before.

Signed-off-by: Flavio Leitner <fbl at sysclose.org>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list