[ovs-git] [openvswitch/ovs] c360a9: pinctrl: Fix memory leak

GitHub noreply at github.com
Tue Jan 23 00:39:27 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: c360a98c3db59da436c9d71442d2b6d242a67a8d
      https://github.com/openvswitch/ovs/commit/c360a98c3db59da436c9d71442d2b6d242a67a8d
  Author: Yifeng Sun <pkusunyifeng at gmail.com>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M ovn/controller/pinctrl.c

  Log Message:
  -----------
  pinctrl: Fix memory leak

This bug is reported by valgrind (testing ovn -- 3 HVs, 1 LS, 3 lports/HV):

51,680 (27,968 direct, 23,712 indirect) bytes in 76 blocks are definitely lost in loss record 72 of 72
   at 0x4C2FB55: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x4A8992: xcalloc (util.c:103)
   by 0x493052: ovsdb_idl_index_init_row (ovsdb-idl.c:2343)
   by 0x413F69: send_ipv6_ras (pinctrl.c:1321)
   by 0x413F69: pinctrl_run (pinctrl.c:1093)
   by 0x407348: main (ovn-controller.c:703)

Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 22407d311344ae32dfd2533fd332605b5407ea61
      https://github.com/openvswitch/ovs/commit/22407d311344ae32dfd2533fd332605b5407ea61
  Author: Yifeng Sun <pkusunyifeng at gmail.com>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M ovn/northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Fix memory leak

This leak was reported by valgrind (testing ovn -- IPv6 Neighbor
Solicitation for unknown MAC):

3,027 bytes in 49 blocks are definitely lost in loss record 210 of 218
    by 0x484C84: xrealloc (util.c:131)
    by 0x43CE41: ds_reserve (dynamic-string.c:63)
    by 0x43D29D: ds_put_format_valist (dynamic-string.c:161)
    by 0x43D3A3: ds_put_format (dynamic-string.c:142)
    by 0x412EEF: ovn_port_update_sbrec (ovn-northd.c:1948)
    by 0x4148B4: build_ports (ovn-northd.c:2109)
    by 0x4148B4: ovnnb_db_run.isra.37 (ovn-northd.c:6202)
    by 0x406FE0: main (ovn-northd.c:6854)

Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: a34eba019c4a247e96b3aaed24ce6d11fa5ec372
      https://github.com/openvswitch/ovs/commit/a34eba019c4a247e96b3aaed24ce6d11fa5ec372
  Author: Yifeng Sun <pkusunyifeng at gmail.com>
  Date:   2018-01-22 (Mon, 22 Jan 2018)

  Changed paths:
    M ovsdb/ovsdb-client.c

  Log Message:
  -----------
  ovsdb-client: Fix memory leaks

This two leaks are reported by valgrind (testing ovsdb-client
backup and restore):

890 (56 direct, 834 indirect) bytes in 1 blocks are definitely lost in loss record 71 of 73
   by 0x42DE22: xcalloc (util.c:103)
   by 0x40DD8C: ovsdb_schema_create (ovsdb.c:34)
   by 0x40E0B5: ovsdb_schema_from_json (ovsdb.c:196)
   by 0x406DA5: fetch_schema (ovsdb-client.c:415)
   by 0x408478: do_restore (ovsdb-client.c:1595)
   by 0x405BCD: main (ovsdb-client.c:170)

2,688 (88 direct, 2,600 indirect) bytes in 1 blocks are definitely lost in loss record 73 of 73
   by 0x42DE84: xmalloc (util.c:120)
   by 0x40E61F: ovsdb_create (ovsdb.c:329)
   by 0x40BA22: ovsdb_file_open__ (file.c:201)
   by 0x40845A: do_restore (ovsdb-client.c:1592)
   by 0x405BCD: main (ovsdb-client.c:170)

Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/a1ba48e0f711...a34eba019c4a


More information about the git mailing list