[ovs-git] [openvswitch/ovs] 46ab60: classifier: Refactor interface for classifier_remo...

GitHub noreply at github.com
Wed Jan 31 19:20:49 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 46ab60bfe562f3ee6cde94888930e9ef9130831f
      https://github.com/openvswitch/ovs/commit/46ab60bfe562f3ee6cde94888930e9ef9130831f
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-01-31 (Wed, 31 Jan 2018)

  Changed paths:
    M lib/classifier.c
    M lib/classifier.h
    M lib/ovs-router.c
    M lib/tnl-ports.c
    M ofproto/ofproto.c
    M tests/test-classifier.c
    M tests/test-ovn.c
    M utilities/ovs-ofctl.c

  Log Message:
  -----------
  classifier: Refactor interface for classifier_remove().

Until now, classifier_remove() returned either null or the classifier rule
passed to it, which is an unusual interface.  This commit changes it to
return true if it succeeds or false on failure.

In addition, most of classifier_remove()'s callers know ahead of time that
it must succeed, even though most of them didn't bother with an assertion,
so this commit adds a classifier_remove_assert() function as a helper.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Tested-by: Yifeng Sun <pkusunyifeng at gmail.com>
Reviewed-by: Yifeng Sun <pkusunyifeng at gmail.com>




More information about the git mailing list