[ovs-git] [openvswitch/ovs] 128b46: checkpatch: fix patch separator line regex

GitHub noreply at github.com
Tue Jul 3 18:42:02 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 128b46a077e8cf50ec830258b6206c4ef252d469
      https://github.com/openvswitch/ovs/commit/128b46a077e8cf50ec830258b6206c4ef252d469
  Author: Aaron Conole <aconole at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M utilities/checkpatch.py

  Log Message:
  -----------
  checkpatch: fix patch separator line regex

The separator line always starts with three dashes on a line, optionally
followed by either white-space, OR a single space and a filename.  The
regex would previously match on any three dashes in a row.  This means
that a patch (such as [1]) would trigger the parser state machine to
advance beyond the signed-off checks.

Now, bound the check only to use what git-mailinfo would use as a
separator.
   --- <filename>
   ---<sp>

1: https://mail.openvswitch.org/pipermail/ovs-dev/2018-June/348625.html

Fixes: c599d5ccf316 ("checkpatch.py: A simple script for finding patch issues")
Signed-off-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list