[ovs-git] [openvswitch/ovs] 128ac9: db-ctl-base: Don't die in parse_column_names() on ...

GitHub noreply at github.com
Tue Jul 3 20:50:22 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 128ac95e0c31a310df7e052a6303d9c38bfdca0b
      https://github.com/openvswitch/ovs/commit/128ac95e0c31a310df7e052a6303d9c38bfdca0b
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in parse_column_names() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: d44cf05efb90b6725934028e9d053bcdc6557d5a
      https://github.com/openvswitch/ovs/commit/d44cf05efb90b6725934028e9d053bcdc6557d5a
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in get_table() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: e09b3af3e249b82aaf19e6d889d1d896881314e2
      https://github.com/openvswitch/ovs/commit/e09b3af3e249b82aaf19e6d889d1d896881314e2
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in is_condition_satisfied() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Also, rename the function as it is no longer a typical predicate, so
that the users don't assume that the result is passed in return value.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: e85ec8e8a5f6ac82c3f5f8e7a0263800a7b2ef1f
      https://github.com/openvswitch/ovs/commit/e85ec8e8a5f6ac82c3f5f8e7a0263800a7b2ef1f
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in check_mutable() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 79c1a00fb5a5ff93658e0f0b910d45fc2354d6af
      https://github.com/openvswitch/ovs/commit/79c1a00fb5a5ff93658e0f0b910d45fc2354d6af
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in set_column() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 9065ca453aa33f9271aeba39cfcafa63ff7ae607
      https://github.com/openvswitch/ovs/commit/9065ca453aa33f9271aeba39cfcafa63ff7ae607
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in create_symbol() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 28fcaca6a43bfd34a0b5fc29b04f192c325a9e52
      https://github.com/openvswitch/ovs/commit/28fcaca6a43bfd34a0b5fc29b04f192c325a9e52
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in get_row_by_id() on multiple matches.

Signal that multiple rows match the record identifier via a new output
parameter instead of reporting the problem and dying, so that the caller
can handle the error without terminating the process if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 73c0d4508da4f327df945dcefebf6905313df11a
      https://github.com/openvswitch/ovs/commit/73c0d4508da4f327df945dcefebf6905313df11a
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c
    M lib/db-ctl-base.h
    M ovn/utilities/ovn-sbctl.c

  Log Message:
  -----------
  db-ctl-base: Don't die in ctl_get_row() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 87e2227246af1c564a91d7cf064e2d045ef68ebd
      https://github.com/openvswitch/ovs/commit/87e2227246af1c564a91d7cf064e2d045ef68ebd
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in pre_get_column() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: c835e589515c9ed49ead1c443409958cd2242ca2
      https://github.com/openvswitch/ovs/commit/c835e589515c9ed49ead1c443409958cd2242ca2
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in pre_get_table() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 7ecbc7f618a2f53bc9fa47279d82409b7be3636a
      https://github.com/openvswitch/ovs/commit/7ecbc7f618a2f53bc9fa47279d82409b7be3636a
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in pre_parse_column_key_value() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Also, we no longer return the column as it was not used by any of
existing callers.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 0e8e4c8f8d1efea3024cda70f5156473daf4466a
      https://github.com/openvswitch/ovs/commit/0e8e4c8f8d1efea3024cda70f5156473daf4466a
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in pre_list_columns() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: fd26f9a2bd3d119facc45d54f24484b7a3db9221
      https://github.com/openvswitch/ovs/commit/fd26f9a2bd3d119facc45d54f24484b7a3db9221
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c
    M lib/db-ctl-base.h
    M ovn/utilities/ovn-nbctl.c
    M utilities/ovs-vsctl.c

  Log Message:
  -----------
  db-ctl-base: Don't die in ctl_set_column() on error.

Return the error message to the caller instead of reporting it and dying
so that the caller can handle the error without terminating the process
if needed.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 675b152e999f5c22a2949c330feb04f8e7b6b991
      https://github.com/openvswitch/ovs/commit/675b152e999f5c22a2949c330feb04f8e7b6b991
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c
    M lib/db-ctl-base.h
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M utilities/ovs-vsctl.c
    M vtep/vtep-ctl.c

  Log Message:
  -----------
  db-ctl-base: Extend ctl_context with an error message.

Prepare for the command handlers (pre_cmd_*() cmd_*() functions) to
report errors by storing them in the context.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: dd712844a558f9b4e6ae169fa74cc07c6dfc75ea
      https://github.com/openvswitch/ovs/commit/dd712844a558f9b4e6ae169fa74cc07c6dfc75ea
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Stop using die_if_error().

Propagate the error via the context for the caller to handle it.

Result of applying the following semantic patch (Coccinelle):

@@
expression s;
@@
- die_if_error(s);
+ ctx->error = s;
+ if (ctx->error) {
+     return;
+ }

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 02c56d5532ab99fa42eb1d703bb8708deb5e5f6e
      https://github.com/openvswitch/ovs/commit/02c56d5532ab99fa42eb1d703bb8708deb5e5f6e
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Fix resource deallocation on error path in cmd_get().

Release resources now that we are returning to the caller on error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 93e6bda51a866806b41c1cb237416d703583ca55
      https://github.com/openvswitch/ovs/commit/93e6bda51a866806b41c1cb237416d703583ca55
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Fix resource deallocation on error path in cmd_list().

Release resources now that we are returning to the caller on error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: d4f720a060b7c9318b143de1f19111aa56bb3740
      https://github.com/openvswitch/ovs/commit/d4f720a060b7c9318b143de1f19111aa56bb3740
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Fix resource deallocation on error path in cmd_find().

Release resources now that we are returning to the caller on error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: f06d958c38bcd63f609c7dde8c570638647a6cb8
      https://github.com/openvswitch/ovs/commit/f06d958c38bcd63f609c7dde8c570638647a6cb8
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Kill die_if_error() helper.

All users are gone.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 0268e922e229afa43988fead4ff7bcee93f34aa6
      https://github.com/openvswitch/ovs/commit/0268e922e229afa43988fead4ff7bcee93f34aa6
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in cmd_get() on error.

Return the error via the context instead of calling ctl_fatal() so that
the caller can decide how to handle it.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 1c4f051bee956637266cb5fbaf2aaacc36ca28d5
      https://github.com/openvswitch/ovs/commit/1c4f051bee956637266cb5fbaf2aaacc36ca28d5
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in cmd_remove() on error.

Return the error via the context instead of calling ctl_fatal() so that
the caller can decide how to handle it.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: d0adfd7756ddc627c569957febe0fdf529dc7414
      https://github.com/openvswitch/ovs/commit/d0adfd7756ddc627c569957febe0fdf529dc7414
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in cmd_clear() on error.

Return the error via the context instead of calling ctl_fatal() so that
the caller can decide how to handle it.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: e7cd8cfc5af02397149ef0872c172bffcdcb4e98
      https://github.com/openvswitch/ovs/commit/e7cd8cfc5af02397149ef0872c172bffcdcb4e98
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-03 (Tue, 03 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in cmd_destroy() on error.

Return the error via the context instead of calling ctl_fatal() so that
the caller can decide how to handle it.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/128b46a077e8...e7cd8cfc5af0
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list