[ovs-git] [openvswitch/ovs] 7521e0: ofproto-dpif: Let the dpif report when a port is a...

GitHub noreply at github.com
Thu Jul 5 22:00:06 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 7521e0cf9e88a62f2feff4e7253654557f94877e
      https://github.com/openvswitch/ovs/commit/7521e0cf9e88a62f2feff4e7253654557f94877e
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-07-05 (Thu, 05 Jul 2018)

  Changed paths:
    M lib/dpif.c
    M ofproto/ofproto-dpif.c

  Log Message:
  -----------
  ofproto-dpif: Let the dpif report when a port is a duplicate.

The port_add() function checks whether the port about to be added to the
dpif is already present and adds it only if it is not.  This duplicates a
check also present (and necessary) in each dpif and races with it as well.
When a dpif has a large number of ports, the check can be expensive (it is
not efficiently implemented).  It would be nice to made the check cheaper,
but it also seems reasonable to do as done in this patch and just let the
dpif report the duplication.

Reported-by: Haifeng Lin <haifeng.lin at huawei.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>
Signed-off-by: Ben Pfaff <blp at ovn.org>



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list