[ovs-git] [openvswitch/ovs] 192ab8: db-ctl-base: Don't die in cmd_add() on error.

GitHub noreply at github.com
Mon Jul 9 22:53:48 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 192ab8d8dcb010acdd3f1c4f3eb35432692fe2a6
      https://github.com/openvswitch/ovs/commit/192ab8d8dcb010acdd3f1c4f3eb35432692fe2a6
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Don't die in cmd_add() on error.

Return the error via the context instead of calling ctl_fatal() so that
the caller can decide how to handle it.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: e7f2c2fce1078326440bb906467178e37a88f0c1
      https://github.com/openvswitch/ovs/commit/e7f2c2fce1078326440bb906467178e37a88f0c1
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Report the actual error from the command handler.

Fix a typo that went undetected by tests because we don't have any test
cases for error paths when using database commands with ovn-nbctl.

Fixes: 675b152e999f ("db-ctl-base: Extend ctl_context with an error message.")
Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: d2eb598c5be6a5d7cc41d9100e82495595a8c1f2
      https://github.com/openvswitch/ovs/commit/d2eb598c5be6a5d7cc41d9100e82495595a8c1f2
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in ls_by_name_or_uuid().

Let the caller handle the error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 3ec52ecee50d313f391376ed1fc6f2b63dd6d998
      https://github.com/openvswitch/ovs/commit/3ec52ecee50d313f391376ed1fc6f2b63dd6d998
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in lsp_by_name_or_uuid().

Let the caller handle the error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 31cd8e4ee00a88c140e1cf0df81bc8ca0863f471
      https://github.com/openvswitch/ovs/commit/31cd8e4ee00a88c140e1cf0df81bc8ca0863f471
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in lb_by_name_or_uuid()

Let the caller handle the error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: c6172a2417f54e8604dc7d112e17251eed4e18ed
      https://github.com/openvswitch/ovs/commit/c6172a2417f54e8604dc7d112e17251eed4e18ed
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in lr_by_name_or_uuid().

Let the caller handle the error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: fa97165089d2778e002eb0670186cdff12970ee3
      https://github.com/openvswitch/ovs/commit/fa97165089d2778e002eb0670186cdff12970ee3
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in lrp_by_name_or_uuid().

Let the caller handle the error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: f72454b07708a17721c141ca5b7e522441d55316
      https://github.com/openvswitch/ovs/commit/f72454b07708a17721c141ca5b7e522441d55316
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in acl_cmd_get_pg_or_ls().

Let the caller handle the error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 71603b019fdd2597c4923195f1661d63983c9ff4
      https://github.com/openvswitch/ovs/commit/71603b019fdd2597c4923195f1661d63983c9ff4
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in parse_enabled().

Let the caller handle the error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 327dc02827dc53e1ecb6433b8e5dec2985767fe8
      https://github.com/openvswitch/ovs/commit/327dc02827dc53e1ecb6433b8e5dec2985767fe8
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_ls_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 365e73f005186707abe681142a6981ca313ca3ce
      https://github.com/openvswitch/ovs/commit/365e73f005186707abe681142a6981ca313ca3ce
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_ls_del().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: c821a5782d94c5be583852c114fdf4d4d83135f4
      https://github.com/openvswitch/ovs/commit/c821a5782d94c5be583852c114fdf4d4d83135f4
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lsp_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: cac6eb96cc6745235d1b8a50ca76de112d6f507b
      https://github.com/openvswitch/ovs/commit/cac6eb96cc6745235d1b8a50ca76de112d6f507b
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_acl().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 5de75b95cbc87ff45bd79134980e129b8648b7b1
      https://github.com/openvswitch/ovs/commit/5de75b95cbc87ff45bd79134980e129b8648b7b1
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_qos_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 0be16b442dd00e08f8bb4e97343ccfab5ebf1ebe
      https://github.com/openvswitch/ovs/commit/0be16b442dd00e08f8bb4e97343ccfab5ebf1ebe
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lr_nat_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: b1bd079a482db871e83d04cae6425ff14e6468da
      https://github.com/openvswitch/ovs/commit/b1bd079a482db871e83d04cae6425ff14e6468da
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lr_nat_del().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 4ac1562979b7a9c022765db89f81a07d1e940440
      https://github.com/openvswitch/ovs/commit/4ac1562979b7a9c022765db89f81a07d1e940440
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lb_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 06737b0023af3c2ed0387c3185246c0acf452502
      https://github.com/openvswitch/ovs/commit/06737b0023af3c2ed0387c3185246c0acf452502
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lb_del()

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 1502ee01ba7fd2734223901bb28a0987887c08e9
      https://github.com/openvswitch/ovs/commit/1502ee01ba7fd2734223901bb28a0987887c08e9
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_ls_lb_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: aad4fa52ea102ce52c65c72cd7eb8c61943457bb
      https://github.com/openvswitch/ovs/commit/aad4fa52ea102ce52c65c72cd7eb8c61943457bb
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lr_lb_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 99c39a632eb3a88fc460221a937af468fb87186e
      https://github.com/openvswitch/ovs/commit/99c39a632eb3a88fc460221a937af468fb87186e
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lr_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 6ea802ca5e4e11a65e803c44f357a8874a5add51
      https://github.com/openvswitch/ovs/commit/6ea802ca5e4e11a65e803c44f357a8874a5add51
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lr_del().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 45dd2071a1264650d75719f3bff08475f76b4ad7
      https://github.com/openvswitch/ovs/commit/45dd2071a1264650d75719f3bff08475f76b4ad7
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lrp_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 28f1e369d3d050146a383c235b899b6bd5ee9248
      https://github.com/openvswitch/ovs/commit/28f1e369d3d050146a383c235b899b6bd5ee9248
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lrp_set_gateway_chassis().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 57cce4825ada712fe17453aa7c272861e1152afd
      https://github.com/openvswitch/ovs/commit/57cce4825ada712fe17453aa7c272861e1152afd
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lrp_get_gateway_chassis().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: ac1875aede70cf61e08b196ad284f41fc713907d
      https://github.com/openvswitch/ovs/commit/ac1875aede70cf61e08b196ad284f41fc713907d
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lrp_del_gateway_chassis().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: afce57b99e034d3a8578a6979e989563e17c8736
      https://github.com/openvswitch/ovs/commit/afce57b99e034d3a8578a6979e989563e17c8736
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lrp_set_enabled().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 1d2b0d4577e97e798300b233ffd938f71bb6c74c
      https://github.com/openvswitch/ovs/commit/1d2b0d4577e97e798300b233ffd938f71bb6c74c
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lr_route_add().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 5a3d7045fa963c044ebb5feed97f429f1ec23552
      https://github.com/openvswitch/ovs/commit/5a3d7045fa963c044ebb5feed97f429f1ec23552
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lr_route_del().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: aaf0016add4f049e86d9572589ae9ab6232e2db8
      https://github.com/openvswitch/ovs/commit/aaf0016add4f049e86d9572589ae9ab6232e2db8
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-09 (Mon, 09 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in nbctl_lsp_set_type().

Propagate the error via the context instead.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/98af55fce855...aaf0016add4f
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list