[ovs-git] [openvswitch/ovs] 6f231f: xlate: use const struct in6_addr in linklocal chec...

GitHub noreply at github.com
Tue Jul 10 16:18:22 UTC 2018

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 6f231f7c3a9ed51617b3d284dd5bf6fd82b3d7bd
  Author: Aaron Conole <aconole at redhat.com>
  Date:   2018-07-10 (Tue, 10 Jul 2018)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  xlate: use const struct in6_addr in linklocal check

Commit 83c2757bd16e ("xlate: Move tnl_neigh_snoop() to
terminate_native_tunnel()") introduced a call to
IN6_IS_ADDR_MC_LINKLOCAL() when checking neighbor discovery.

The call to this assumes that the argument may be a const uint8_t *.
According to The Open Group Base Specifications Issue 7, 2018:

    macro is of type int and takes a single argument of
    type const struct in6_addr *

The GNU implementation allows a bit of flexibility, by internally
casting the argument.  However, other implementations (such as OS X)
more rigidly implement the standard and fail with errors like:

    error: member reference base type 'const uint8_t'
     (aka 'const unsigned char') is not a structure or union

Fixes: 83c2757bd16e ("xlate: Move tnl_neigh_snoop() to terminate_native_tunnel()")
Cc: Zoltan Balogh <zoltan.balogh.eth at gmail.com>
Cc: Jan Scheurich <jan.scheurich at ericsson.com>
Signed-off-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.

More information about the git mailing list