[ovs-git] [openvswitch/ovs] 218ac8: ovn-nbctl: Don't die in pg_by_name_or_uuid().

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 218ac8681b69d80441129d65b64059a108971511
      https://github.com/openvswitch/ovs/commit/218ac8681b69d80441129d65b64059a108971511
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c
    M tests/ovn-nbctl.at

  Log Message:
  -----------
  ovn-nbctl: Don't die in pg_by_name_or_uuid().

Let the caller handle the error. This prepares us for reporting errors
in daemon mode.

Also, extend the tests to cover this error path.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: ca0a24fda3f1dad74c7a2eb7999edb9ed08f623d
      https://github.com/openvswitch/ovs/commit/ca0a24fda3f1dad74c7a2eb7999edb9ed08f623d
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in gc_by_name_or_uuid().

Let the caller handle the error. This prepares us for reporting errors
in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: ae00c11003ec6c265704d669939bfcfa8aae9210
      https://github.com/openvswitch/ovs/commit/ae00c11003ec6c265704d669939bfcfa8aae9210
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in lsp_to_ls().

Let the caller handle the error. This prepares us for reporting errors
in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: b69e3d29d886f3c5e04d857893c8edc5c9e9564c
      https://github.com/openvswitch/ovs/commit/b69e3d29d886f3c5e04d857893c8edc5c9e9564c
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in lrp_to_lr().

Let the caller handle the error. This prepares us for reporting errors
in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: bc8223df3b01c1daae2b108ad3e324c6b75eb848
      https://github.com/openvswitch/ovs/commit/bc8223df3b01c1daae2b108ad3e324c6b75eb848
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in parse_priority().

Let the caller handle the error. This prepares us for reporting errors
in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: a139410789e7aafc74631ed4c0e7103312bb2a52
      https://github.com/openvswitch/ovs/commit/a139410789e7aafc74631ed4c0e7103312bb2a52
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in parse_direction().

Let the caller handle the error. This prepares us for reporting errors
in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 3844c85de979febe69c77766ae0baaf1d2b407e9
      https://github.com/openvswitch/ovs/commit/3844c85de979febe69c77766ae0baaf1d2b407e9
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't die in dhcp_options_get().

Let the caller handle the error. This prepares us for reporting errors
in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: e162f6078f0c18708a7d422bb15fbccb16b5b0f6
      https://github.com/openvswitch/ovs/commit/e162f6078f0c18708a7d422bb15fbccb16b5b0f6
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Propagate error thru the context.

Instead of dying let the main loop handle the error.
This will allow us to report errors when running in daemon mode.

This is a result of applying the following semantic patch:

@@
identifier F;
identifier C;
identifier E;
@@
  static void F(struct ctl_context *C) {
<...
      if (E) {
-         ctl_fatal("%s", E);
+         C->error = E;
+         return;
      }
...>
  }

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: f7049514f1dc38e832e718013578f1647d423e85
      https://github.com/openvswitch/ovs/commit/f7049514f1dc38e832e718013578f1647d423e85
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Use ctl_error() in command handlers.

Instead of dying with ctl_fatal(), propagate the error thru the context.
This will allow us to report errors when running in daemon mode.

This patch is a result of applying the following semantic patch:

@@
identifier F, C;
expression S;
@@
  static void F(struct ctl_context *C) {
<...
-     ctl_fatal(S);
+     ctl_error(C, S);
+     return;
...>
  }
@@
identifier F, C;
expression S, A;
@@
  static void F(struct ctl_context *C) {
<...
-     ctl_fatal(S, A);
+     ctl_error(C, S, A);
+     return;
...>
  }

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 1d06fb2639f4186d09ab3b831eb812610bd3247e
      https://github.com/openvswitch/ovs/commit/1d06fb2639f4186d09ab3b831eb812610bd3247e
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Remove pointless "return; " at ends of functions.

Fix fall-out from applying a semantic patch that converts ctl_fatal()
calls to use ctl_error().

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: e48864f1c52487aed2fabd36d28e019475547b11
      https://github.com/openvswitch/ovs/commit/e48864f1c52487aed2fabd36d28e019475547b11
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Fix mem leak in nbctl_lrp_set_gateway_chassis().

Fix fall-out from applying a semantic patch to propagate the error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/3c921cc2b6b7...e48864f1c524
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.