[ovs-git] [openvswitch/ovs] db3f70: table: Introduce a constant for default table styl...

Mon Jul 23 23:46:04 UTC 2018

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: db3f700b64594b4eaa8707e452330e8248227101
      https://github.com/openvswitch/ovs/commit/db3f700b64594b4eaa8707e452330e8248227101
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M lib/table.h

  Log Message:
  -----------
  table: Introduce a constant for default table style.

Having a constant in addition to the constant expression for the default
table style allows us to reset 'struct table_style' variables to default
style.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: ef744a72337a6ed249781d11aece76bf43958e7f
      https://github.com/openvswitch/ovs/commit/ef744a72337a6ed249781d11aece76bf43958e7f
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M lib/ovsdb-idl.c

  Log Message:
  -----------
  ovsdb-idl: Allow monitoring columns that are already monitored.

If IDL was created with monitoring and alerts turned on by default for
all columns, then there is no harm in allowing the API users to ask
again for monitoring and alerts to be enabled for any given column.

This allows us to run prerequisites handlers for db-ctl and ovn-nbctl
commands once the IDL has already ran once.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 5c02f562409d5f077b883cfbe1f0a1729cb4a7ab
      https://github.com/openvswitch/ovs/commit/5c02f562409d5f077b883cfbe1f0a1729cb4a7ab
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Extract the main loop.

Split out a routine for the main ovn-nbctl loop.

Preparatory work for introducing daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 0d1eed891024f18be7b6ee50220fea6f343a6e2e
      https://github.com/openvswitch/ovs/commit/0d1eed891024f18be7b6ee50220fea6f343a6e2e
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Pull up destroying commands from do_nbctl().

Destroy commands in the same routine where they were allocated.

Preparatory work for reusing the main loop in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 01c9c5110a032ca41f66c3651c0b59ed05aec36c
      https://github.com/openvswitch/ovs/commit/01c9c5110a032ca41f66c3651c0b59ed05aec36c
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Pull up releasing IDL from do_nbctl().

Destroy IDL resources in the routine where we allocated them.

Preparatory work for reusing the main loop in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 65391fdf15e0e875d52fe3a4756fe27dfb6d5f7c
      https://github.com/openvswitch/ovs/commit/65391fdf15e0e875d52fe3a4756fe27dfb6d5f7c
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Signal need to try again via an output param.

Introduce an output parameter for the flag that signals need to retry
running the command. This leaves the return value for error reporting.

Preparatory work for reusing the main loop in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 08e13d4686686e62445df9d8e87b6803a974b4f5
      https://github.com/openvswitch/ovs/commit/08e13d4686686e62445df9d8e87b6803a974b4f5
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Don't destroy the transaction twice on error.

Reset the global state, if transaction succeeded. Otherwise nbctl_exit()
callback will try to clean up on any fatal error.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 6441935951b35cef5ef654e5d19963ae338f9bb7
      https://github.com/openvswitch/ovs/commit/6441935951b35cef5ef654e5d19963ae338f9bb7
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c

  Log Message:
  -----------
  db-ctl-base: Propagate error from parse_command().

Let the caller handle the error. Needed for ovn-nbctl daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: a95199f26a773a90d5ff71be7d9734f9fb963170
      https://github.com/openvswitch/ovs/commit/a95199f26a773a90d5ff71be7d9734f9fb963170
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M lib/db-ctl-base.c
    M lib/db-ctl-base.h
    M ovn/utilities/ovn-nbctl.c
    M ovn/utilities/ovn-sbctl.c
    M utilities/ovs-vsctl.c
    M vtep/vtep-ctl.c

  Log Message:
  -----------
  db-ctl-base: Propagate errors from the commands parser.

Let the caller decide how to handle the error. Prepare for using the
parser in ovn-nbctl daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 8999210c03a7cd9e2277549a5b37e3beb29b8f2e
      https://github.com/openvswitch/ovs/commit/8999210c03a7cd9e2277549a5b37e3beb29b8f2e
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Propagate the error from do_nbctl().

Instead of terminating the process, return the error to the caller.

This will allow us to reuse the main loop in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: cd8b0d28a06c33aad590cf9e976975c5b4755b91
      https://github.com/openvswitch/ovs/commit/cd8b0d28a06c33aad590cf9e976975c5b4755b91
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Propagate errors from the main loop.

Let the caller handle the errors instead of reporting it and
terminating. Prepare for reusing the main loop in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 63523207f1bcd15660f9d3623ffdb3c56a40af75
      https://github.com/openvswitch/ovs/commit/63523207f1bcd15660f9d3623ffdb3c56a40af75
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Propagate errors from prerequisites runner.

Instead of terminating the process, return the error to the caller.

This will allow us to reuse the prerequisites runner in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: ed30290dc3db90f7e649b6328c318ed97b34d97d
      https://github.com/openvswitch/ovs/commit/ed30290dc3db90f7e649b6328c318ed97b34d97d
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Introduce a poll_timer based wait timeout.

Extend the main loop and the command runner so that the caller can
specify a timeout for poll_block(). This will allow us to break out of
the main loop when waiting on IDL, like in the blocked '--wait=sb/hv
sync' case.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 5b0d1663c3415131e4416b6c70110cc53c261eb0
      https://github.com/openvswitch/ovs/commit/5b0d1663c3415131e4416b6c70110cc53c261eb0
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Extract helper for printing oneline output.

This will allow us to direct oneline-formatted output to other sinks
than stdout if needed. Preparatory work for daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 994955541f9123359b2040b1b2287e1a72c7fb5a
      https://github.com/openvswitch/ovs/commit/994955541f9123359b2040b1b2287e1a72c7fb5a
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Extract handling of options that affect main loop.

Provide a handler for options that change how the main loop behaves.

This will allow code reuse for option parsing in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: ae60817e3a73e901937bd1d755dab7a59a08b184
      https://github.com/openvswitch/ovs/commit/ae60817e3a73e901937bd1d755dab7a59a08b184
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Extract a helper for building short options string.

Will be reused for parsing options in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 2324215d053d82991a03849bdbbbb25b28226459
      https://github.com/openvswitch/ovs/commit/2324215d053d82991a03849bdbbbb25b28226459
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Extract a helper for appending command options.

Will be reused when parsing options in daemon mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 3ec06ea9c668483e56cb5ae92eb34fd2aff712f9
      https://github.com/openvswitch/ovs/commit/3ec06ea9c668483e56cb5ae92eb34fd2aff712f9
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M ovn/utilities/ovn-nbctl.8.xml
    M ovn/utilities/ovn-nbctl.c

  Log Message:
  -----------
  ovn-nbctl: Initial support for daemon mode.

Make ovn-nbctl act as a unixctl server if we were asked to detach. This
turns ovn-nbctl into a long-lived process that acts a proxy for
interacting with NB DB. The main difference to regular mode of ovn-nbctl
is that in the daemon mode, a local copy of database contents has to be
obtained only once.

Just two unixctl commands are supported 'run' and 'exit'. The former can
be used to run any ovn-nbctl command or a batch of them as so:

  ovs-appctl -t ovn-nbctl run [OPTIONS] COMMAND [-- [OPTIONS] COMMAND] ...

Running commands that have not yet been converted to not use ctl_fatal()
will result in death of the daemon process. However, --monitor option
can be used to keep the daemon running.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: a745e0cee5e828cc59061bbf1c574350d9e5a582
      https://github.com/openvswitch/ovs/commit/a745e0cee5e828cc59061bbf1c574350d9e5a582
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M tests/ovn-nbctl.at

  Log Message:
  -----------
  tests: Add test for ovn-nbctl dry run mode.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 6c9a48dacc45f2fdd4eb06d8828f82db3d6b6e42
      https://github.com/openvswitch/ovs/commit/6c9a48dacc45f2fdd4eb06d8828f82db3d6b6e42
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M tests/ovn-nbctl.at

  Log Message:
  -----------
  tests: Add test for oneline-formatted output for ovn-nbctl.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: d1b235d7a6246e00d4afc359071d3b6b3ed244c3
      https://github.com/openvswitch/ovs/commit/d1b235d7a6246e00d4afc359071d3b6b3ed244c3
  Author: Jakub Sitnicki <jkbs at redhat.com>
  Date:   2018-07-23 (Mon, 23 Jul 2018)

  Changed paths:
    M tests/ovn-nbctl.at

  Log Message:
  -----------
  tests: Add test for ovn-nbctl's command parser error paths.

Preparatory work for getting rid of ctl_fatal() in command parser.

Signed-off-by: Jakub Sitnicki <jkbs at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

Compare: https://github.com/openvswitch/ovs/compare/e48864f1c524...d1b235d7a624
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.