[ovs-git] [openvswitch/ovs] 3e0319: compat: Initialize IPv4 reassembly secret timer

GitHub noreply at github.com
Fri Jul 27 18:38:09 UTC 2018


  Branch: refs/heads/branch-2.7
  Home:   https://github.com/openvswitch/ovs
  Commit: 3e03197fcd5ca1b341ef8b09cc0c6fe9889e85a1
      https://github.com/openvswitch/ovs/commit/3e03197fcd5ca1b341ef8b09cc0c6fe9889e85a1
  Author: Greg Rose <gvrose8192 at gmail.com>
  Date:   2018-07-27 (Fri, 27 Jul 2018)

  Changed paths:
    M datapath/datapath.c
    M datapath/linux/compat/ip_fragment.c
    M datapath/linux/compat/nf_conntrack_reasm.c

  Log Message:
  -----------
  compat: Initialize IPv4 reassembly secret timer

The RHEL 7 kernels expect the secret timer interval to be initialized
before calling the inet_frags_init() function.  By not initializing it
the inet_frags_secret_rebuild() function was running on every tick
rather than on the expected interval.  This caused occasional panics
from page faults when inet_frags_secret_rebuild() would try to rearm a
timer from the openvswitch kernel module which had just been removed.

Also remove the prior, and now unnecessary, work around.

VMware BZ 2094203

Fixes: 595e069a ("compat: Backport IPv4 reassembly.")
Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list