[ovs-git] [openvswitch/ovs] 1a7f79: ofctrl: Placate GCC.

GitHub noreply at github.com
Tue Jul 31 17:15:55 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 1a7f7969d397b21943977aa02da927a299fc8e76
      https://github.com/openvswitch/ovs/commit/1a7f7969d397b21943977aa02da927a299fc8e76
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-07-31 (Tue, 31 Jul 2018)

  Changed paths:
    M ovn/controller/ofctrl.c

  Log Message:
  -----------
  ofctrl: Placate GCC.

Some GCC versions don't like ".x.y =", complaining about an uninitialized
field.

Without this patch we get travis failures, e.g.
https://travis-ci.org/openvswitch/ovs/jobs/410404752:

    ovn/controller/ofctrl.c: In function ‘ofctrl_put’:
    ovn/controller/ofctrl.c:1086:9: error: missing initializer for field ‘flags’ of ‘struct ofputil_meter_config’ [-Werror=missing-field-initializers]
       };
       ^
    In file included from ovn/controller/ofctrl.c:35:0:
    ./include/openvswitch/ofp-meter.h:53:14: note: ‘flags’ declared here
   uint16_t flags;
            ^

With it, it passes.

Fixes: 185b13f228ac ("ovn: Add Meter and Meter_Band tables to the NB and SB databases.")
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list