[ovs-git] [openvswitch/ovs] ae6f75: ofp-actions: Split ofpacts_check__() into many fun...

GitHub noreply at github.com
Tue Jul 31 20:16:51 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: ae6f7530bff39c62d3b7d1baab93623d8f5f3db1
      https://github.com/openvswitch/ovs/commit/ae6f7530bff39c62d3b7d1baab93623d8f5f3db1
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-07-31 (Tue, 31 Jul 2018)

  Changed paths:
    M include/openvswitch/ofp-actions.h
    M lib/ofp-actions.c
    M lib/ofp-flow.c
    M ofproto/ofproto-dpif-trace.c
    M ofproto/ofproto.c
    M utilities/ovs-ofctl.c

  Log Message:
  -----------
  ofp-actions: Split ofpacts_check__() into many functions.

ofpacts_check__() was a huge switch statement with special cases for many
different kinds of actions.  This made it unwieldy and put the special
cases far away from the rest of the code related to a given action.  This
commit refactors the code to avoid the problem.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Tested-by: Yifeng Sun <pkusunyifeng at gmail.com>
Reviewed-by: Yifeng Sun <pkusunyifeng at gmail.com>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list