[ovs-git] [openvswitch/ovs] 225c33: ofp-protocol: Better abstract changing the protoco...

GitHub noreply at github.com
Wed Mar 14 18:45:38 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 225c33ba64a4de1aa30b05f8549c0628fe7fe6e3
      https://github.com/openvswitch/ovs/commit/225c33ba64a4de1aa30b05f8549c0628fe7fe6e3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M include/openflow/nicira-ext.h
    M include/openvswitch/ofp-flow.h
    M include/openvswitch/ofp-msgs.h
    M include/openvswitch/ofp-protocol.h
    M lib/ofp-flow.c
    M lib/ofp-print.c
    M lib/ofp-protocol.c
    M ofproto/ofproto.c

  Log Message:
  -----------
  ofp-protocol: Better abstract changing the protocol used for flow matches.

The previous interface here required the client to understand, to some
extent, the low-level NXFF_* values and the encoding format for the
NXT_SET_FLOW_FORMAT and NXT_SET_FLOW_MOD_TABLE_ID messages.  This commit
changes the interface so that the client only has to understand the
ofputil_protocol type used elsewhere and none of the encoding otherwise.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: d8790c08437106f1d71960330e4e35de4fef16f6
      https://github.com/openvswitch/ovs/commit/d8790c08437106f1d71960330e4e35de4fef16f6
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M include/openflow/nicira-ext.h
    M include/openvswitch/ofp-msgs.h
    M include/openvswitch/ofp-packet.h
    M lib/ofp-packet.c
    M lib/ofp-print.c
    M ofproto/connmgr.c
    M ofproto/connmgr.h
    M ofproto/ofproto.c
    M ovn/controller/pinctrl.c
    M utilities/ovs-ofctl.c

  Log Message:
  -----------
  ofp-packet: Better abstract packet-in format.

This commit relieves the caller of code that deals with the format of
packet-in messages from some of the burden of understanding the packet
format.  It also renames the constants to appear to be at a higher level of
abstraction.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: 0960a98b7720c74e0ae873933ca9d5d4d089c6f5
      https://github.com/openvswitch/ovs/commit/0960a98b7720c74e0ae873933ca9d5d4d089c6f5
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M lib/ofp-flow.c
    M lib/ofp-parse.c

  Log Message:
  -----------
  ofp-flow: Move parse_ofp_flow_mod_str() into correct file.

This function was left behind by accident in the patch that split up
ofp-parse.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: 11b1e59f3af06a3ab02496abbb65564a077744a7
      https://github.com/openvswitch/ovs/commit/11b1e59f3af06a3ab02496abbb65564a077744a7
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M include/openvswitch/ofp-match.h
    M lib/ofp-match.c

  Log Message:
  -----------
  ofp-match: Make some public functions static.

These were only used inside ofp-match itself.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: dfc77282c52f324c19a6819372c2ec17675bc7ce
      https://github.com/openvswitch/ovs/commit/dfc77282c52f324c19a6819372c2ec17675bc7ce
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-03-14 (Wed, 14 Mar 2018)

  Changed paths:
    M include/openvswitch/netdev.h
    M include/openvswitch/ofp-errors.h
    M include/openvswitch/ofp-flow.h
    M include/openvswitch/ofp-match.h
    M include/openvswitch/ofp-monitor.h
    M include/openvswitch/ofp-packet.h
    M include/openvswitch/ofp-port.h
    M include/openvswitch/ofp-print.h
    M include/openvswitch/ofp-switch.h
    M include/openvswitch/ofp-table.h
    M include/openvswitch/ofp-util.h
    M lib/netdev.c
    M lib/ofp-errors.c
    M lib/ofp-flow.c
    M lib/ofp-match.c
    M lib/ofp-monitor.c
    M lib/ofp-packet.c
    M lib/ofp-port.c
    M lib/ofp-print.c
    M lib/ofp-switch.c
    M lib/ofp-table.c
    M lib/ofp-util.c
    M ovn/utilities/ovn-sbctl.c
    M ovn/utilities/ovn-trace.c
    M utilities/ovs-ofctl.c

  Log Message:
  -----------
  ofp-print: Move much of the printing code into message-specific files.

Until now, the ofp-print code has had a lot of logic specific to
individual messages.  This code is better put with the other code specific
to those messages, so this commit starts to migrate it.

There is more work of a similar type to do, but this is a reasonable start.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/62bba609351a...dfc77282c52f


More information about the git mailing list