[ovs-git] [openvswitch/ovs] 1a75e0: Avoid crash in OvS while transmitting fragmented p...

[GitHub]

  Branch: refs/heads/branch-2.8
  Home:   https://github.com/openvswitch/ovs
  Commit: 1a75e02b1b5e3a9ca5a1fb904da17022c86e9084
      https://github.com/openvswitch/ovs/commit/1a75e02b1b5e3a9ca5a1fb904da17022c86e9084
  Author: Rohith Basavaraja <rohith.basavaraja at ericsson.com>
  Date:   2018-05-09 (Wed, 09 May 2018)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  -----------
  Avoid crash in OvS while transmitting fragmented packets over tunnel.

Currently when fragmented packets are to be transmitted in to tunnel,
base_flow->nw_frag which was initially non-zero at reception is not
reset to zero when the base_flow and flow are rewritten
as part of the emulated tnl_push action in the ofproto-dpif-xlate
module.

Because of this when fragmented packets are transmitted out of tunnel,
we hit crash caused by the following assert.

lib/odp-util.c:5654: assertion flow->nw_proto == base_flow->nw_proto &&
flow->nw_frag == base_flow->nw_frag failed in commit_set_ipv4_action()

With the following change propagate_tunnel_data_to_flow__
is modified to reset *nw_frag* to zero. Also, that currently we don't
fragment tunnelled packets, we should reset *nw_frag* to zero in
propagate_tunnel_data_to_flow__.

Signed-off-by: Jan Scheurich <jan.scheurich at ericsson.com>
From: Rohith Basavaraja <rohith.basavaraja at ericsson.com>
CC: Jan Scheurich <jan.scheurich at ericsson.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>



      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.