[ovs-git] [openvswitch/ovs] 926145: ofproto-dpif-xlate: Fix reference leak in xlate_dp...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 92614555eca6f438c6894edad8b36decb5f79b45
      https://github.com/openvswitch/ovs/commit/92614555eca6f438c6894edad8b36decb5f79b45
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-05-17 (Thu, 17 May 2018)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  -----------
  ofproto-dpif-xlate: Fix reference leak in xlate_dp_hash_select_group().

xlate_group_action() takes a reference to the ofgroup and passes it
down to xlate_group_action__(), xlate_select_group(), and finally to
xlate_dp_hash_select_group(), which is supposed to consume it but fails
to do so.  This commit fixes the problem.

Found by inspection.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: a04e58881e25f6b687f5635abc695724c5153782
      https://github.com/openvswitch/ovs/commit/a04e58881e25f6b687f5635abc695724c5153782
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-05-17 (Thu, 17 May 2018)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  -----------
  ofproto-dpif-xlate: Simplify translation for groups.

Translation of groups had a lot of redundant code.  This commit eliminates
most of it.  It should also make it harder to accidentally reintroduce
the reference leak fixed in a previous commit.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: 720c104c93ecb3954890a4b25bf03af668026f63
      https://github.com/openvswitch/ovs/commit/720c104c93ecb3954890a4b25bf03af668026f63
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-05-17 (Thu, 17 May 2018)

  Changed paths:
    M lib/ofp-group.c

  Log Message:
  -----------
  ofp-group: Require watch_port or watch_group when parsing ff groups.

Fast failover buckets must have a watch_port or a watch_group (or both),
and ovs-vswitchd enforces this, but the bucket parsing code didn't check
it.  This meant that when it was omitted, the error messages were harder
to understand.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: 7b809df9529d32f61e5b501366ae1f99ed84c9e5
      https://github.com/openvswitch/ovs/commit/7b809df9529d32f61e5b501366ae1f99ed84c9e5
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-05-17 (Thu, 17 May 2018)

  Changed paths:
    M NEWS
    M include/openflow/openflow-1.5.h
    M include/openvswitch/ofp-errors.h
    M include/openvswitch/ofp-msgs.h
    M lib/nx-match.c
    M lib/ofp-group.c
    M lib/ofp-print.c
    M tests/ofp-print.at
    M tests/ofproto.at
    M utilities/ovs-ofctl.8.in

  Log Message:
  -----------
  Add OpenFlow extensions for group support in OpenFlow 1.0.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: e9c9481f3b01bc08808c253235f1d3faae2cb09a
      https://github.com/openvswitch/ovs/commit/e9c9481f3b01bc08808c253235f1d3faae2cb09a
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-05-17 (Thu, 17 May 2018)

  Changed paths:
    M include/openvswitch/ofp-group.h
    M lib/ofp-group.c
    M lib/ofp-print.c

  Log Message:
  -----------
  ofp-group: Move formatting code for groups into ofp-group.

This does a better job of putting related code together.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: e428148a1fb0f2bf8e7d2829220b849a82cd081c
      https://github.com/openvswitch/ovs/commit/e428148a1fb0f2bf8e7d2829220b849a82cd081c
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-05-17 (Thu, 17 May 2018)

  Changed paths:
    M include/openvswitch/ofp-msgs.h
    M lib/ofp-msgs.c
    M lib/ofp-print.c
    M tests/ofp-print.at

  Log Message:
  -----------
  ofp-print: Handle statistics more systematically.

ofp_to_string__() is supposed to call ofp_print_stats() for all kinds of
statistics, but it was only doing so haphazardly.  This commit makes it
systematic and in the process adds it to at least one case where it was
missing (and fixes up a test case).

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: fac4786a1b94ffc85eeb32a2b6b98f7b40740975
      https://github.com/openvswitch/ovs/commit/fac4786a1b94ffc85eeb32a2b6b98f7b40740975
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-05-17 (Thu, 17 May 2018)

  Changed paths:
    M ofproto/ofproto-dpif-trace.c
    M ofproto/ofproto-dpif-trace.h
    M ofproto/ofproto-dpif-xlate.c
    M tests/nsh.at

  Log Message:
  -----------
  ofproto-dpif-xlate: Improve tracing through groups.

This makes it clear which buckets from a group are executed and why.

The update to nsh.at provides an example.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/481bde499a5d...fac4786a1b94
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.