[ovs-git] [openvswitch/ovs] 97b0c7: netdev-dpdk: Remove use of rte_mempool_ops_get_cou...

[GitHub]

  Branch: refs/heads/branch-2.8
  Home:   https://github.com/openvswitch/ovs
  Commit: 97b0c7e0a929d59d1fd252f825877e5b197d02f3
      https://github.com/openvswitch/ovs/commit/97b0c7e0a929d59d1fd252f825877e5b197d02f3
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Remove use of rte_mempool_ops_get_count.

rte_mempool_ops_get_count is not exported by DPDK so it means it
cannot be used by OVS when using DPDK as a shared library.

Remove rte_mempool_ops_get_count but still use rte_mempool_full
and document it's behavior.

Fixes: 91fccdad72a2 ("netdev-dpdk: Free mempool only when no in-use mbufs.")
Reported-by: Timothy Redaelli <tredaelli at redhat.com>
Reported-by: Markos Chandras <mchandras at suse.de>
Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: ff0030591f57d1bcb601c009373099f99743447d
      https://github.com/openvswitch/ovs/commit/ff0030591f57d1bcb601c009373099f99743447d
  Author: Eelco Chaudron <echaudro at redhat.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M lib/dpif-netdev.c
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Don't use PMD driver if not configured successfully

When initialization of the DPDK PMD driver fails
(dpdk_eth_dev_init()), the reconfigure_datapath() function will remove
the port from dp_netdev, and the port is not used.

Now when bridge_reconfigure() is called again, no changes to the
previous failing netdev configuration are detected and therefore the
ports gets added to dp_netdev and used uninitialized. This is causing
exceptions...

The fix has two parts to it. First in netdev-dpdk.c we remember if the
DPDK port was started or not, and when calling
netdev_dpdk_reconfigure() we also try re-initialization if the port
was not already active. The second part of the change is in
dpif-netdev.c where it makes sure netdev_reconfigure() is called if
the port needs reconfiguration, as netdev_is_reconf_required() is only
true until netdev_reconfigure() is called (even if it fails).

Signed-off-by: Eelco Chaudron <echaudro at redhat.com>
Tested-by: Ciara Loftus <ciara.loftus at intel.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: adaae1414f243c0710b42999545824065d205baa
      https://github.com/openvswitch/ovs/commit/adaae1414f243c0710b42999545824065d205baa
  Author: Timothy Redaelli <tredaelli at redhat.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: fix check for "net_nfp" driver

Currently the check of "net_nfp" driver while enabling scatter compares
only the first 6 bytes, but "net_nfp" is 7 bytes long.

This change fixes the check by comparing the first 7 bytes.

CC: Pablo Cascón <pablo.cascon at netronome.com>
CC: Simon Horman <simon.horman at netronome.com>
Fixes: 65a87968f4cf ("netdev-dpdk: don't enable scatter for jumbo RX support for nfp")
Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
Acked-by: Pablo Cascón <pablo.cascon at netronome.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 72a113554b1391124883f2cd6d13357be41699ae
      https://github.com/openvswitch/ovs/commit/72a113554b1391124883f2cd6d13357be41699ae
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Free packets on TUNNEL_PUSH if may_steal.

Unconditional return may cause packet leak in case of
'may_steal == true'.

Additionally, removed redundant checking for depth level and
clarified ignoring of the 'false' value of 'may_steal'.

CC: Sugesh Chandran <sugesh.chandran at intel.com>
Fixes: 7c12dfc527a5 ("tunneling: Avoid datapath-recirc by
                combining recirc actions at xlate.")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 983938bdea3b5692a3038aef082dd87ede3bd9a8
      https://github.com/openvswitch/ovs/commit/983938bdea3b5692a3038aef082dd87ede3bd9a8
  Author: Ian Stokes <ian.stokes at intel.com>
  Date:   2018-05-24 (Thu, 24 May 2018)

  Changed paths:
    M NEWS

  Log Message:
  -----------
  NEWS: Add LSC support for DPDK.

LSC support was previously added but no entry was made to the NEWS
document. Fix this by adding it to NEWS for OVS 2.8.3.

Signed-off-by: Ian Stokes <ian.stokes at intel.com>
Acked-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/8b10a2632b84...983938bdea3b
      **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.