[ovs-git] [openvswitch/ovs] d5cc46: ipsec: Use @PYTHON@ directly instead of "/usr/bin/...

GitHub noreply at github.com
Sat Nov 10 16:27:08 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: d5cc46e3d185dcd32e2ef099b2ce38e1a7f95eee
      https://github.com/openvswitch/ovs/commit/d5cc46e3d185dcd32e2ef099b2ce38e1a7f95eee
  Author: Timothy Redaelli <tredaelli at redhat.com>
  Date:   2018-11-10 (Sat, 10 Nov 2018)

  Changed paths:
    M configure.ac
    M ipsec/automake.mk
    R ipsec/ovs-monitor-ipsec
    A ipsec/ovs-monitor-ipsec.in

  Log Message:
  -----------
  ipsec: Use @PYTHON@ directly instead of "/usr/bin/env python"

Using "/usr/bin/env" is against Fedora Packaging Guidelines [1].

Moreover, in this specific case, it also prevent "make rpm-fedora" to
successfully complete on "Fedora Rawhide" since "#!/usr/bin/env python"
must not be used anymore [2].

[1] https://fedoraproject.org/wiki/Packaging:Guidelines#Shebang_lines
[2] https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error

CC: Qiuyu Xiao <qiuyu.xiao.qyx at gmail.com>
Fixes: 22c5eafb6efa ("ipsec: reintroduce IPsec support for tunneling")
Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list