[ovs-git] [openvswitch/ovs] 954b6d: expr: Disallow < <= >= > comparisons against empty...

GitHub noreply at github.com
Thu Oct 11 20:48:21 UTC 2018


  Branch: refs/heads/branch-2.10
  Home:   https://github.com/openvswitch/ovs
  Commit: 954b6da5f52f01df724c72c9c44260f50b7fb9b6
      https://github.com/openvswitch/ovs/commit/954b6da5f52f01df724c72c9c44260f50b7fb9b6
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-11 (Thu, 11 Oct 2018)

  Changed paths:
    M ovn/lib/expr.c
    M tests/ovn.at

  Log Message:
  -----------
  expr: Disallow < <= >= > comparisons against empty value set.

OVN expression syntax does not allow a literal empty value set, like {}.
Rather, any literal value set has to have at least one value.  However,
value sets that originate from address sets or from port groups can be
empty.  In such a case, == and != comparisons are allowed but < <= >= >
should be errors.  The actual implementation failed to properly disallow
the latter and instead tried to access the first element of the value set,
a bad read.  This fixes the problem.

Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10731
Reported-at: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10767
Signed-off-by: Ben Pfaff <blp at ovn.org>
Reviewed-by: Yifeng Sun <pkusunyifeng at gmail.com>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list