[ovs-git] [openvswitch/ovs] 4c7a43: ovn-ctl: Fix the wrong pidfile argument passed to ...

GitHub noreply at github.com
Fri Oct 12 00:41:41 UTC 2018


  Branch: refs/heads/branch-2.9
  Home:   https://github.com/openvswitch/ovs
  Commit: 4c7a432154a7b379cd97d26a51caaa155f35b449
      https://github.com/openvswitch/ovs/commit/4c7a432154a7b379cd97d26a51caaa155f35b449
  Author: Numan Siddique <nusiddiq at redhat.com>
  Date:   2018-10-11 (Thu, 11 Oct 2018)

  Changed paths:
    M ovn/utilities/ovn-ctl

  Log Message:
  -----------
  ovn-ctl: Fix the wrong pidfile argument passed to ovsdb-servers

When OVN db servers are started usinb ovn-ctl, if the pid files
(/var/run/openvswitch/ovnnb_db.pid for example) are already
present, then ovn-ctl passes "--pidfile=123" if the pid file has
'123' stored in it. Later on when OVN pacemaker RA script calls
status_ovnnb/status_ovnsb() functions, these returns "not running".

The shell function 'pidfile_is_running()' stores the contents of
the pid file as  "pid=`cat "$pidfile"`". If the caller also
uses the same variable "pid" to store the file name, it gets
overriden.

This patch fixes this issue by renaming the local variable "pid"
in the "start_ovsdb__()" shell function to "db_file_name".

Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list