[ovs-git] [openvswitch/ovs] 042b8f: connmgr: Suppress duplicate port status notificati...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 042b8f42c6d20347916c70a058615d8b7470a319
      https://github.com/openvswitch/ovs/commit/042b8f42c6d20347916c70a058615d8b7470a319
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-18 (Thu, 18 Oct 2018)

  Changed paths:
    M ofproto/connmgr.c
    M ofproto/connmgr.h
    M ofproto/ofproto.c
    M tests/lacp.at

  Log Message:
  -----------
  connmgr: Suppress duplicate port status notifications.

When the status of a port changes, ofproto calls into connmgr to notify
controllers.  Sometimes, particular changes are only visible to controllers
running specific versions of OpenFlow.  Until now, OVS would send those
controllers duplicate port status notifications.  This is unnecessary and
somewhat confusing.  This commit eliminates it.

This commit updates one of the tests not to expect duplicate notifications.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusididq at redhat.com>


  Commit: b40fc02aed70f6bd2af613801904647ba5c674a8
      https://github.com/openvswitch/ovs/commit/b40fc02aed70f6bd2af613801904647ba5c674a8
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-18 (Thu, 18 Oct 2018)

  Changed paths:
    M ofproto/ofproto.c

  Log Message:
  -----------
  ofproto: Refactor update_port().

update_port() worked a little too hard to avoid copying and comparing some
bits in the ofputil_phy_port.  This seems like a simpler approach all
around.  It should behave the same way.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusididq at redhat.com>


  Commit: 16361b111b5091c7d18221e06f83d26998881863
      https://github.com/openvswitch/ovs/commit/16361b111b5091c7d18221e06f83d26998881863
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-18 (Thu, 18 Oct 2018)

  Changed paths:
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto-provider.h
    M ofproto/ofproto.c

  Log Message:
  -----------
  ofproto: Move may_enable from ofport_dpif to ofport.

This concept of whether a port is suitable to be "live" in the sense of the
OpenFlow OFPPS_LIVE bit is a generic one that can be handled at the ofproto
layer instead of needing to be part of ofproto-dpif.

An upcoming commit will make more use of this at the ofproto layer.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusididq at redhat.com>


  Commit: 1273c5733c346c835c753e1a42a67e7458ec30c6
      https://github.com/openvswitch/ovs/commit/1273c5733c346c835c753e1a42a67e7458ec30c6
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-18 (Thu, 18 Oct 2018)

  Changed paths:
    M ofproto/ofproto-dpif.c

  Log Message:
  -----------
  ofproto-dpif: Refactor port_run().

This makes port_run() easier to understand but should not change its
behavior.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusididq at redhat.com>


  Commit: 6d57dea9649a562e0f7a97fcab936ddf36a15009
      https://github.com/openvswitch/ovs/commit/6d57dea9649a562e0f7a97fcab936ddf36a15009
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-18 (Thu, 18 Oct 2018)

  Changed paths:
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto-provider.h
    M ofproto/ofproto.c

  Log Message:
  -----------
  ofproto: Consistently force off OFPPS_LIVE if port or link is down.

It doesn't make sense for a port that is down to be "live" from OpenFlow's
point of view, but this could happen in OVS.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusididq at redhat.com>


  Commit: c9c8c8a1502a4fa255a920ca37e0d1d3603eecb0
      https://github.com/openvswitch/ovs/commit/c9c8c8a1502a4fa255a920ca37e0d1d3603eecb0
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-18 (Thu, 18 Oct 2018)

  Changed paths:
    M lib/netdev-dummy.c
    M tests/ofproto-dpif.at
    M tests/ofproto.at

  Log Message:
  -----------
  netdev-dummy: Initialize new dummy ports as "up".

Dummy ports started out down and hardly any of the tests ever brought them
up.  This led to some odd test results and caused problems for testing with
controllers that didn't bother with ports that were down, like recent
versions of Faucet.  There doesn't seem to be a big reason for them to be
down by default, so this commit changes them to be up by default.  It also
updates the tests to match the new behavior.

Reported-by: Brad Cowie <brad at cowie.nz>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-August/047234.html
Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusididq at redhat.com>


Compare: https://github.com/openvswitch/ovs/compare/229486c2dfa9...c9c8c8a1502a
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.