[ovs-git] [openvswitch/ovs] df5011: vconn: Avoid null dereference on error path.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: df50117721bcefb72f95089819d7fbefb22c351c
      https://github.com/openvswitch/ovs/commit/df50117721bcefb72f95089819d7fbefb22c351c
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-26 (Fri, 26 Oct 2018)

  Changed paths:
    M lib/vconn.c

  Log Message:
  -----------
  vconn: Avoid null dereference on error path.

Sometimes the 'errors' list is passed as null, and in that case it should
not be used.

Found by inspection.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: 9d36d7d7289a58d6a14f92896d870695f997d989
      https://github.com/openvswitch/ovs/commit/9d36d7d7289a58d6a14f92896d870695f997d989
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-26 (Fri, 26 Oct 2018)

  Changed paths:
    M include/openvswitch/ofp-table.h
    M lib/ofp-print.c
    M lib/ofp-table.c
    M tests/ofproto-dpif.at
    M tests/ofproto.at
    M utilities/ovs-ofctl.c

  Log Message:
  -----------
  ofp-table: Better summarize table features and statistics.

Before this patch, most dump-table-stats outputs would contain about
250 lines of the form:

  table #: ditto

With this patch, they have one line like this:

  tables 2...254: ditto

which is much easier to read.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: dccab9b15e656c6c1db1b8e94da1e1f234811506
      https://github.com/openvswitch/ovs/commit/dccab9b15e656c6c1db1b8e94da1e1f234811506
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-26 (Fri, 26 Oct 2018)

  Changed paths:
    M lib/ofp-table.c
    M tests/ofproto.at

  Log Message:
  -----------
  ofp-table: Ignore bits that have to change according to OpenFlow.

OpenFlow table feature replies contain a per-table bitmap that indicates
which tables a flow can point to in goto_table actions.  OpenFlow requires
that a table only be able to go to higher-numbered tables.  This means that
a switch that is general as possible will always have different features
for every table, since each one will have a different bitmap.  This makes
the output of "ovs-ofctl dump-table-features" pretty long and ugly because
it has about 250 entries like this:

  table %d:
    metadata: match=0xffffffffffffffff write=0xffffffffffffffff
    max_entries=%d
    instructions (table miss and others):
      next tables: %d-253
      (same instructions)
      (same actions)
    (same matching)

This commit changes the logic that prints table features messages so that
it considers two sequentially numbered tables to be the same if only the
bit that necessarily must be tunred off changes.  This reduces the hundreds
of entries above to just:

   tables 1...253: ditto

which is so much more readable.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


  Commit: b47e7e2bac7f21f8c81aaeb1068598a6064c348b
      https://github.com/openvswitch/ovs/commit/b47e7e2bac7f21f8c81aaeb1068598a6064c348b
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-26 (Fri, 26 Oct 2018)

  Changed paths:
    M include/openvswitch/ofp-table.h
    M lib/ofp-print.c
    M lib/ofp-table.c
    M utilities/ovs-ofctl.c

  Log Message:
  -----------
  ofp-table: Always format the table number in table features.

Table features should indicate the table number as well as the table
name.  Before this, the first line for each table looked like this:
   table myname ("myname"):
but it's more useful if it's:
   table 123 ("myname"):

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Justin Pettit <jpettit at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/98a9272ba2c4...b47e7e2bac7f
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.