[ovs-git] [openvswitch/ovs] 729d2a: ovn-northd: Improve hashing for chassis queues.

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 729d2aaf833791d22f2a3dd3b999615111d41972
      https://github.com/openvswitch/ovs/commit/729d2aaf833791d22f2a3dd3b999615111d41972
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-31 (Wed, 31 Oct 2018)

  Changed paths:
    M ovn/northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Improve hashing for chassis queues.

The key for a "struct ovn_chassis_qdisc_queues" is a Chassis UUID and a
queue_id, but only the UUID was being hashed, so if there was more than one
per chassis then they'd all end up in the same hash bucket, which is
needlessly inefficient.  (And if there's only one per chassis then why do
we bother allocating them at all?)

Found by inspection.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusiddiq at redhat.com>


  Commit: 307912849e2f907fab400502160e7d26f29ccdd3
      https://github.com/openvswitch/ovs/commit/307912849e2f907fab400502160e7d26f29ccdd3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-31 (Wed, 31 Oct 2018)

  Changed paths:
    M ovn/northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Use structure assignment instead of memcpy().

Makes the code easier to read.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusiddiq at redhat.com>


  Commit: 2af1e18c742dff71f716a46f2f7a7a1f35e2c259
      https://github.com/openvswitch/ovs/commit/2af1e18c742dff71f716a46f2f7a7a1f35e2c259
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-10-31 (Wed, 31 Oct 2018)

  Changed paths:
    M ovn/northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Fix memory leak in free_chassis_queueid().

Found by inspection.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Acked-by: Numan Siddique <nusiddiq at redhat.com>


Compare: https://github.com/openvswitch/ovs/compare/21bc775f522e...2af1e18c742d
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.