[ovs-git] [openvswitch/ovs] 427fb0: dpif-netdev: Prevent unsafe access when retrieving...

[GitHub]

  Branch: refs/heads/branch-2.9
  Home:   https://github.com/openvswitch/ovs
  Commit: 427fb0c65bcb5862f3b629c4748474e4398f5dfa
      https://github.com/openvswitch/ovs/commit/427fb0c65bcb5862f3b629c4748474e4398f5dfa
  Author: Justin Pettit <jpettit at ovn.org>
  Date:   2018-09-04 (Tue, 04 Sep 2018)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Prevent unsafe access when retrieving meter stats.

dpif_netdev_meter_get() retrieved a pointer to a meter entry without
holding a lock.  It's possible that another thread could have deleted
that entry between retrieving the pointer and dereferencing the pointer.
This makes the function hold the lock the entire time the meter entry is
needed.

Found by inspection.

Signed-off-by: Justin Pettit <jpettit at ovn.org>
Acked-by: Flavio Leitner <fbl at sysclose.org>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.