[ovs-git] [openvswitch/ovs] 697f59: ovs-macros: Make tests log how long they waited wh...

GitHub noreply at github.com
Wed Sep 5 21:30:31 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 697f5993c0cf437faa7ec6753e8cf47850a44da3
      https://github.com/openvswitch/ovs/commit/697f5993c0cf437faa7ec6753e8cf47850a44da3
  Author: Ben Pfaff <blp at ovn.org>
  Date:   2018-09-05 (Wed, 05 Sep 2018)

  Changed paths:
    M tests/ovn.at
    M tests/ovs-macros.at

  Log Message:
  -----------
  ovs-macros: Make tests log how long they waited when they succeed.

Many OVS tests wait up for 10 seconds for a condition to become true.
Usually these conditions are ones that should take only a second or so to
actually become true in practice, but on a busy and slow machine it's
possible that some tests might fail or come close to failing because 10
seconds is simply not enough there.

This commit adds logging for the case where a condition actually succeeds
to indicate the amount of time that was waited.  This should make it easier
to identify whether we need to increase the maximum wait time from 10
seconds to something longer, by allowing us to see whether some of the
successful waits came close to timing out.

Reported-by: Thomas Goirand <zigo at debian.org>
Reported-at: https://mail.openvswitch.org/pipermail/ovs-discuss/2018-September/047340.html
Signed-off-by: Ben Pfaff <blp at ovn.org>
Tested-by: Thomas Goirand <zigo at debian.org>



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list