[ovs-git] [openvswitch/ovs] 5c6590: sflow: Set agent address properly based on collect...

GitHub noreply at github.com
Thu Sep 27 17:59:08 UTC 2018


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 5c6590ecbe00af7df1e66b879382b3b1c70d3516
      https://github.com/openvswitch/ovs/commit/5c6590ecbe00af7df1e66b879382b3b1c70d3516
  Author: Justin Pettit <jpettit at ovn.org>
  Date:   2018-09-27 (Thu, 27 Sep 2018)

  Changed paths:
    M ofproto/ofproto-dpif-sflow.c

  Log Message:
  -----------
  sflow: Set agent address properly based on collector address.

If an agent address is not provided, OVS tries to choose a source
address based on the source IP that would be used to connect to the
sFlow collector.  The code previously set the agent address to the
collector's address instead of using the calculated source address.
This patch properly uses the source address.

Reported-by: Neil McKee <neil.mckee at inmon.com>
Signed-off-by: Justin Pettit <jpettit at ovn.org>
Acked-by: Ben Pfaff <blp at ovn.org>


  Commit: dc2c9ce38748c506ac67e1adfe52eef154e6fda2
      https://github.com/openvswitch/ovs/commit/dc2c9ce38748c506ac67e1adfe52eef154e6fda2
  Author: Justin Pettit <jpettit at ovn.org>
  Date:   2018-09-27 (Thu, 27 Sep 2018)

  Changed paths:
    M ofproto/ofproto-dpif-xlate.c

  Log Message:
  -----------
  ofproto-dpif-xlate.c: Fix uninitialized variable warning.

With gcc 7.3.0 a warning is given about two variables possibly being
uninitialized in compose_sample_action().  The code path only allows the
variables to be used if they've been initialized, so this warning is
incorrect.  However, this change allows a clean build.

Signed-off-by: Justin Pettit <jpettit at ovn.org>
Acked-by: Flavio Leitner <fbl at sysclose.org>


Compare: https://github.com/openvswitch/ovs/compare/49fd74c27ce8...dc2c9ce38748
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.


More information about the git mailing list