[ovs-git] [openvswitch/ovs] 146ee6: ofproto: Return error codes for rule insertions.

Aravind Prasad S noreply at github.com
Wed Apr 24 00:06:33 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 146ee62626e3b21baf19191460e52ef5cb596e52
      https://github.com/openvswitch/ovs/commit/146ee62626e3b21baf19191460e52ef5cb596e52
  Author: Aravind Prasad S <Aravind.Sridharan at dell.com>
  Date:   2019-04-23 (Tue, 23 Apr 2019)

  Changed paths:
    M ofproto/ofproto-dpif.c
    M ofproto/ofproto-provider.h
    M ofproto/ofproto.c

  Log Message:
  -----------
  ofproto: Return error codes for rule insertions.

Currently, rule_insert() API does not have return value. There are some
possible scenarios where rule insertions can fail at run-time even though the
static checks during rule_construct() had passed previously.  Some possible
scenarios for failure of rule insertions:

**) Rule insertions can fail dynamically in Hybrid mode (both Openflow and
Normal switch functioning coexist) where the CAM space could get suddenly
filled up by Normal switch functioning and Openflow gets devoid of available
space.

**) Some deployments could have separate independent layers for HW rule
insertions and application layer to interact with OVS. HW layer could face any
dynamic issue during rule handling which application could not have
predicted/captured in rule-construction phase.

Rule-insert errors for bundles are handled too.

Testing: Tested failures of rule insertions and also with bundles.

Signed-off-by: Aravind Prasad S <aravind.sridharan at dell.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list