[ovs-git] [openvswitch/ovs] 89f874: ovn-northd: Fix ARP respond flows flapping.

damijans noreply at github.com
Fri Aug 9 18:06:41 UTC 2019


  Branch: refs/heads/branch-2.12
  Home:   https://github.com/openvswitch/ovs
  Commit: 89f874c45b3668cfd736d920b3505bbcbfff240e
      https://github.com/openvswitch/ovs/commit/89f874c45b3668cfd736d920b3505bbcbfff240e
  Author: Han Zhou <hzhou8 at ebay.com>
  Date:   2019-08-09 (Fri, 09 Aug 2019)

  Changed paths:
    M ovn/northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Fix ARP respond flows flapping.

>From ovn-controller debug log it is seen that when creating a lsp
in NB, a lflow for ARP respond is added and then deleted in SB
by northd (the flow will be added again when the port is bound
to a chassis). This causes unnecessary handling from ovn-controller.

The root cause is lsp_is_up() returns true when the column is not
set, when the lsp is just created. So northd adds the ARP respond
flow in SB lflow table. At the same time it will create port-binding
in SB without chassis binding. Then in the next iteration northd
will process that port-binding change and notice that there is no
chassis binding for this lsp, so it will set the "up" to false,
which causes northd to delete the ARP respond flow.

The fix is to make sure when "up" is not set, it is regarded as
false by default.

Signed-off-by: Han Zhou <hzhou8 at ebay.com>
Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
Signed-off-by: Justin Pettit <jpettit at ovn.org>

Backported from OVN branch patch f91b123d33fc.


  Commit: 266c2ae33ab31e737a9cbc3ad8a29aea779ee0fe
      https://github.com/openvswitch/ovs/commit/266c2ae33ab31e737a9cbc3ad8a29aea779ee0fe
  Author: Damijan Skvarc <damjan.skvarc at gmail.com>
  Date:   2019-08-09 (Fri, 09 Aug 2019)

  Changed paths:
    M ovn/controller/physical.c

  Log Message:
  -----------
  Fixed memory leak in ovn-controller while handling port binding changes.

Signed-off-by: Damijan Skvarc <damjan.skvarc at gmail.com>
Acked-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <nusiddiq at redhat.com>
Signed-off-by: Justin Pettit <jpettit at ovn.org>

Backported from OVN branch patch 926271b52f5.


Compare: https://github.com/openvswitch/ovs/compare/ee2bb0f2f989...266c2ae33ab3


More information about the git mailing list