[ovs-git] [openvswitch/ovs] ac3ba8: raft.c: Election timer initial reset with value fr...

Han Zhou noreply at github.com
Fri Aug 23 21:43:12 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: ac3ba8c64830e20fc65ece025f2812edb75c58f2
      https://github.com/openvswitch/ovs/commit/ac3ba8c64830e20fc65ece025f2812edb75c58f2
  Author: Han Zhou <hzhou8 at ebay.com>
  Date:   2019-08-23 (Fri, 23 Aug 2019)

  Changed paths:
    M ovsdb/raft.c

  Log Message:
  -----------
  raft.c: Election timer initial reset with value from log.

After election timer is changed through cluster/change-election-timer
command, if a server restarts, it firstly initializes with the default
value and use it to reset the timer. Although it reads the latest
timer value later from the log, the first timeout may be much shorter
than expected by other servers that use latest timeout, and it would
start election before it receives the first heartbeat from the leader.

This patch fixes it by changing the order of reading log and resetting
timer so that the latest value is read from the log before the initial
resetting of the timer.

Fixes: commit 8e35461 ("ovsdb raft: Support leader election time change online.")
Signed-off-by: Han Zhou <hzhou8 at ebay.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: a76ba8254ddd35b81190c7380fc66b9765e9b9fd
      https://github.com/openvswitch/ovs/commit/a76ba8254ddd35b81190c7380fc66b9765e9b9fd
  Author: Han Zhou <hzhou8 at ebay.com>
  Date:   2019-08-23 (Fri, 23 Aug 2019)

  Changed paths:
    M Documentation/ref/ovsdb.5.rst
    M ovsdb/raft-private.c

  Log Message:
  -----------
  raft: Save and read new election timer in header snapshot.

This patch store the latest election timer in snapshot during log
compression, and when server restarts it reads the value from the log.
Without this, any previous changes to election timer will be lost
in the log, and if server restarts, it will use the default value
instead of the changed value.

Fixes: commit 8e35461 ("ovsdb raft: Support leader election time change online.")
Signed-off-by: Han Zhou <hzhou8 at ebay.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 2110e2bbeee851949dff2d970592d6e36f3f6a80
      https://github.com/openvswitch/ovs/commit/2110e2bbeee851949dff2d970592d6e36f3f6a80
  Author: Han Zhou <hzhou8 at ebay.com>
  Date:   2019-08-23 (Fri, 23 Aug 2019)

  Changed paths:
    M Documentation/ref/ovsdb.5.rst

  Log Message:
  -----------
  ovsdb.5.rst: Fix minor format problem.

Signed-off-by: Han Zhou <hzhou8 at ebay.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/24a4bbe1de11...2110e2bbeee8


More information about the git mailing list