[ovs-git] [openvswitch/ovs] 18366d: netdev-dpdk: Fix not reporting rx_oversize_errors ...

Ilya Maximets noreply at github.com
Mon Aug 26 14:08:43 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 18366d165162051463fd28e9f46d1c2cbe355eb3
      https://github.com/openvswitch/ovs/commit/18366d165162051463fd28e9f46d1c2cbe355eb3
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-08-26 (Mon, 26 Aug 2019)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Fix not reporting rx_oversize_errors in stats.

There is a big code duplication issue with DPDK xstats that led to
missed "rx_oversize_errors" statistics. It's defined but not used.
Fix that by actually using this stat along with code refactoring that
will allow us to not make same mistakes in the future.
Macro definitions are perfectly suitable to automate code generation
in such cases and already used in a couple of places in OVS for similar
purposes.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
Acked-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 5c7ba90d8189ee7b35a1723d5a76dc205720af50
      https://github.com/openvswitch/ovs/commit/5c7ba90d8189ee7b35a1723d5a76dc205720af50
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-08-26 (Mon, 26 Aug 2019)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Refactor vhost custom stats for extensibility.

vHost interfaces currently has only one custom statistic, but there
might be others in the near future. This refactoring makes the code
work in the same way as it done for dpdk and afxdp stats to keep the
common style over the different code places and makes it easily
extensible for the new stats addition.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>


Compare: https://github.com/openvswitch/ovs/compare/c2bb883c0a9a...5c7ba90d8189


More information about the git mailing list