[ovs-git] [openvswitch/ovs] 9e2ed0: dpif-netdev: Fail port addition if reconfiguration...

Ilya Maximets noreply at github.com
Thu Aug 29 15:30:00 UTC 2019

  Branch: refs/heads/branch-2.12
  Home:   https://github.com/openvswitch/ovs
  Commit: 9e2ed0194157e51b65262e23e2b13f13d25e9fec
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-08-29 (Thu, 29 Aug 2019)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  dpif-netdev: Fail port addition if reconfiguration failed.

If the port was destroyed during the initial reconfiguration, we should
report an error to the upper layers. Otherwise, successful addition of
the port will be logged and upper layers will continue to configure
this port. For example, the 'dpif' layer will try to initilaize flow
API for this device.

Fix that by checking for port existence after reconfiguration. We can't
get the real error code here, so let's assume EINVAL. 'ovs-vsctl' will
tell the user to check the logs for a real reason anyway.

Fixes: e32971b8ddb4 ("dpif-netdev: Centralized threads and queues handling code.")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Ian Stokes <ian.stokes at intel.com>

  Commit: 196710cae98f79e2c672135a7c6231c6f33d33b6
  Author: Nitin Katiyar <nitin.katiyar at ericsson.com>
  Date:   2019-08-29 (Thu, 29 Aug 2019)

  Changed paths:
    M lib/packets.c

  Log Message:
  packets: Fix using outdated RSS hash after MPLS decapsulation.

When a packet is received, the RSS hash is calculated if it is not
already available. The Exact Match Cache (EMC) entry is then looked up
using this RSS hash.

When a MPLS encapsulated packet is received, the MPLS header is popped
and the packet is recirculated. Since the RSS hash has not been
invalidated here, the EMC lookup for all decapsulated packets will hit
the same entry even though these packets will have different tuple
values. This degrades performance severely as different inner packets
from the same MPLS tunnel would hit the same EMC entry.

This patch invalidates RSS hash (by resetting offload flags) after MPLS
header is popped.

Signed-off-by: Nitin Katiyar <nitin.katiyar at ericsson.com>
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>

Compare: https://github.com/openvswitch/ovs/compare/91d7ea6312fd...196710cae98f

More information about the git mailing list