[ovs-git] [openvswitch/ovs] 301158: dpif-netdev: Use netdev-offload API for port looku...

Ilya Maximets noreply at github.com
Mon Dec 2 17:18:55 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 30115809da2e263c286319e4d6002baa679ca988
      https://github.com/openvswitch/ovs/commit/30115809da2e263c286319e4d6002baa679ca988
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2019-12-02 (Mon, 02 Dec 2019)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Use netdev-offload API for port lookup while offloading.

Currently, while offloading, userspace datapath tries to lookup netdev
in a local port list of the datapath interface instance.  However,
there is no guarantee that these netdevs are the same netdevs that
netdev-offload module operates with and, as a result, there is no any
guarantee that these netdev instances has initialized flow API.

dpif-netdev should request ports from the netdev-offload module as
intended by flow offloading API in a same way as dpif-netlink does.
This will also give us performance benefits because we don't need to
hold global port mutex anymore.

We're not noticing any significant issues with current code, but
it will become a serious issue in the future, e.g. with offloading
for virtual tunneling ports.

Reported-by: Ophir Munk <ophirmu at mellanox.com>
Fixes: 241bad15d99a ("dpif-netdev: associate flow with a mark id")
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Acked-by: Ophir Munk <ophirmu at mellanox.com>
Acked-by: Eli Britstein <elibr at mellanox.com>




More information about the git mailing list