[ovs-git] [openvswitch/ovs] e7cb12: dpif-netdev: Hold global port mutex while calling ...

Ilya Maximets noreply at github.com
Fri Dec 13 12:49:17 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: e7cb123ffc9d96e6583855222eaafebb16b054a3
      https://github.com/openvswitch/ovs/commit/e7cb123ffc9d96e6583855222eaafebb16b054a3
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2019-12-13 (Fri, 13 Dec 2019)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Hold global port mutex while calling offload API.

We changed datapath port lookup to netdev-offload API usage, but
forgot that port mutex was there not only to protect datapath
port hash map.  It was there also as a workaround solution for
complete unsafety of netdev-offload-dpdk functions.

Turning it back to fix the behaviour and adding a comment to prevent
removing it in the future unless netdev-offload-dpdk fixed.

For the thread safety notice see the top of netdev-offload-dpdk.c.

Fixes: 30115809da2e ("dpif-netdev: Use netdev-offload API for port lookup while offloading")
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Acked-by: Eli Britstein <elibr at mellanox.com>




More information about the git mailing list