[ovs-git] [openvswitch/ovs] b6b4f5: travis: Fix building datapath instead of userspace...

Mon Feb 11 16:44:21 UTC 2019

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: b6b4f5b8cf7cab321345a92a8a8dd90b63853c0e
      https://github.com/openvswitch/ovs/commit/b6b4f5b8cf7cab321345a92a8a8dd90b63853c0e
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M .travis/linux-build.sh

  Log Message:
  -----------
  travis: Fix building datapath instead of userspace with DPDK_SHARED.

Current script does not check build of OVS with DPDK.
It builds datapath instead.

CC: Ian Stokes <ian.stokes at intel.com>
Fixes: edfe8d263d2e ("travis: Add dpdk shared library build.")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Acked-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: b95cd0e505e310285cdc4c5ce655a84a28d25a58
      https://github.com/openvswitch/ovs/commit/b95cd0e505e310285cdc4c5ce655a84a28d25a58
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M datapath/linux/Makefile.main.in

  Log Message:
  -----------
  datapath: Clean up some gcov, tmp and cache files.

'distcheck' complains about these files while building --with-linux.

  ERROR: files left in build directory after distclean:
  ./datapath/linux/.tmp_ip6_gre.gcno
  ./datapath/linux/.tmp_ip_tunnels_core.gcno
  ./datapath/linux/.tmp_genetlink-openvswitch.gcno
  ./datapath/linux/.tmp_stt.gcno
  <..>
  ./datapath/linux/.tmp_versions/vport-gre.mod
  ./datapath/linux/.tmp_versions/vport-geneve.mod
  ./datapath/linux/.tmp_versions/vport-vxlan.mod
  ./datapath/linux/.tmp_versions/vport-lisp.mod
  ./datapath/linux/.tmp_versions/vport-stt.mod
  <..>
  ./datapath/linux/.dev-openvswitch.o.d
  ./datapath/linux/.ip_tunnels_core.o.d
  ./datapath/linux/.vport.o.d
  ./datapath/linux/.udp_tunnel.o.d
  ./datapath/linux/.cache.mk

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 914ea15d854c2106992d2f10ee9429ee07ae2b02
      https://github.com/openvswitch/ovs/commit/914ea15d854c2106992d2f10ee9429ee07ae2b02
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M include/openvswitch/automake.mk

  Log Message:
  -----------
  automake: Clean up cxxtest.cc.

'distcheck' complains on some configurations:

  ERROR: files left in build directory after distclean:
  ./include/openvswitch/cxxtest.cc

CC: Ben Pfaff <blp at ovn.org>
Fixes: 994bfc298502 ("Automatically verify that OVS header files work OK in C++ also.")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 8e7d5b6434bccb01e0403620df9114e77ac8a244
      https://github.com/openvswitch/ovs/commit/8e7d5b6434bccb01e0403620df9114e77ac8a244
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M .travis/linux-build.sh

  Log Message:
  -----------
  travis: Run testsuite with desired options.

'make distcheck' executes it's own './configure' without any options
provided to the script. This means that in current configuration
Travis CI always re-builds and runs testsuite on a defualt binaries.
i.e. we're not checking testsuite with DPDK, not checking testsuite
with '--enable-shared' and not checking it with '-ljemalloc'.
We just 8 times running the testsuite without arguments. Only compiler
changes (gcc or clang) because CC is exported by Travis.

This patch reorders the commands in the build script and provides
'DISTCHECK_CONFIGURE_FLAGS' to force 'make distcheck' using our
desired configuration.

Another issue that addressed here is that we will no longe build
twice in case of TESTSUITE.

For linking inside the distcheck we also need to provide absulute path
to DPDK libraries.

'configure' executed before 'distcheck' to have a Makefile target.
It's executed without arguments because 'configure' inside the
'distcheck' will fail if we'll use sparse-wrapped CC.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: ad68ace08ea4ee0f5b97607dae604cf246707864
      https://github.com/openvswitch/ovs/commit/ad68ace08ea4ee0f5b97607dae604cf246707864
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M .travis/linux-build.sh

  Log Message:
  -----------
  travis: Dump config.log on configure failures.

Useful for debugging.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 13429e3299128e4d9d87b2e10e1cd164f91e92ae
      https://github.com/openvswitch/ovs/commit/13429e3299128e4d9d87b2e10e1cd164f91e92ae
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M .travis/linux-build.sh

  Log Message:
  -----------
  travis: Enable printing of executed commands.

This increases the output by a few lines, but gives important
information regarding commands and their exact arguments.
Very useful for debugging.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 0fdc054fd1cefba550a838e6e1e8118a19e5a384
      https://github.com/openvswitch/ovs/commit/0fdc054fd1cefba550a838e6e1e8118a19e5a384
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M .travis/linux-build.sh
    M .travis/linux-prepare.sh

  Log Message:
  -----------
  travis: Use parallel jobs for DPDK and sparse builds.

This allows to save a few minutes.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: a8b12ea59c7e7c32bb041480776c032fe341a0ef
      https://github.com/openvswitch/ovs/commit/a8b12ea59c7e7c32bb041480776c032fe341a0ef
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  travis: Drop redundant DPDK build check.

This check covered by 'TESTSUITE=1 DPDK=1'.
No need to run it separately.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

  Commit: 1f6daa7311bfe683cb563278a2776d21b8564d8f
      https://github.com/openvswitch/ovs/commit/1f6daa7311bfe683cb563278a2776d21b8564d8f
  Author: Timothy Redaelli <tredaelli at redhat.com>
  Date:   2019-02-11 (Mon, 11 Feb 2019)

  Changed paths:
    M utilities/ovs-lib.in

  Log Message:
  -----------
  ovs-lib.in: Cleanup old socket and pidfiles in stop_daemon

Currently if a client crashes (signal 11) the unix socket (.ctl) and the
pidfile may not be deleted when you use ovs-ctl stop or restart.

Moreover since ovs-appctl is used on a closed socket some warnings are
printed.

This commit deletes the pidfile and the unix socket then returns without
running ovs-appctl if the pidfile point to a not-existing pid.

Reported-at: https://bugzilla.redhat.com/1667845
Reported-by: Candido Campos <ccamposr at redhat.com>
Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>

Compare: https://github.com/openvswitch/ovs/compare/0227bf092ee6...1f6daa7311bf