[ovs-git] [openvswitch/ovs] 865cee: acinclude: Check for rte_config.h before checking ...

istokes noreply at github.com
Tue Feb 12 17:12:01 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 865cee2baa1a07d17be6797c7f228e21c891b79b
      https://github.com/openvswitch/ovs/commit/865cee2baa1a07d17be6797c7f228e21c891b79b
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-02-12 (Tue, 12 Feb 2019)

  Changed paths:
    M acinclude.m4

  Log Message:
  -----------
  acinclude: Check for rte_config.h before checking dependencies.

Current ./configure script shows misleading errors in case of wrong
DPDK path:

  # ./configure --with-dpdk=/wrong/path
  ...
  checking whether dpdk datapath is enabled... yes
  checking for library containing get_mempolicy... -lnuma
  checking for library containing pcap_dump... -lpcap
  checking for library containing mnl_attr_put... no
  configure: error: unable to find libmnl, install the dependency package

This happens because we're not checking for headers before checking
for dependencies. All the compile attempts fails and script thinks
that we need more dependencies.

With this change script will check for 'rte_config.h' availability
and produce sane error message:

  # ./configure --with-dpdk=/wrong/path
  ...
  checking for rte_config.h... no
  configure: error: unable to find rte_config.h in /wrong/path

'AC_INCLUDES_DEFAULT' passed explicitly to avoid preprocessor test.

Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>




More information about the git mailing list