[ovs-git] [openvswitch/ovs] 6a5c8d: dhparams: Add pregenerated .c file to the repository.

Timothy Redaelli noreply at github.com
Fri Feb 22 20:35:12 UTC 2019


  Branch: refs/heads/branch-2.6
  Home:   https://github.com/openvswitch/ovs
  Commit: 6a5c8d1d3581e6a31de9394bf3648d621e2409d3
      https://github.com/openvswitch/ovs/commit/6a5c8d1d3581e6a31de9394bf3648d621e2409d3
  Author: Eneas U de Queiroz <cote2004-github at yahoo.com>
  Date:   2019-02-22 (Fri, 22 Feb 2019)

  Changed paths:
    M Makefile.am
    A build-aux/generate-dhparams-c
    M lib/.gitignore
    M lib/automake.mk
    A lib/dhparams.c

  Log Message:
  -----------
  dhparams: Add pregenerated .c file to the repository.

The version of dhparams.c generated by any given version of OpenSSL or
LibreSSL might work only with that version of the library.  This can be
inconvenient for cross-compiling if the "openssl" program on the build
machine has a different version from the library on the host where OVS will
run, since it could generate code that won't compile.

This commit fixes the problem by generating dhparams.c that works on the
currently important versions of OpenSSL and LibreSSL.

Submitted-at: https://github.com/openvswitch/ovs/pull/235
Signed-off-by: Eneas U de Queiroz <cote2004-github at yahoo.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: ffe8f8d86f2da8a775fbfded8957ed136509c1d4
      https://github.com/openvswitch/ovs/commit/ffe8f8d86f2da8a775fbfded8957ed136509c1d4
  Author: Timothy Redaelli <tredaelli at redhat.com>
  Date:   2019-02-22 (Fri, 22 Feb 2019)

  Changed paths:
    M build-aux/generate-dhparams-c

  Log Message:
  -----------
  dhparams: Fix .c file generation with OpenSSL >= 1.1.1-pre9

Since OpenSSL upstream commit 201b305a2409
("apps/dsaparam.c generates code that is intended to be pasted or included into
an existing source file: the function is static, and the code doesn't include
dsa.h.  Match the generated C source style of dsaparam.") "openssl dhparam -C"
generates the get_dh functions as static, but the functions are used inside
stream-ssl.c and so the static keyword cannot be used.

This commit removes the static keyword from the get_dh functions during
dhparams.c file generation by restoring the current behaviour.

Signed-off-by: Timothy Redaelli <tredaelli at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/3b938c1d7d36...ffe8f8d86f2d


More information about the git mailing list