[ovs-git] [openvswitch/ovs] 5177ec: Revert "dpif-netlink: Don't destroy and recreate p...

GitHub noreply at github.com
Sat Jan 26 03:10:34 UTC 2019


  Branch: refs/heads/branch-2.11
  Home:   https://github.com/openvswitch/ovs
  Commit: 5177ec2dd1027a1cdb09571a8ad35de1d1532394
      https://github.com/openvswitch/ovs/commit/5177ec2dd1027a1cdb09571a8ad35de1d1532394
  Author: Flavio Leitner <fbl at redhat.com>
  Date:   2019-01-25 (Fri, 25 Jan 2019)

  Changed paths:
    M lib/dpif-netlink.c

  Log Message:
  -----------
  Revert "dpif-netlink: Don't destroy and recreate port if it exists"

This reverts commit  a38dccb3ee80a1d0b8973191c9e94f045441f8cc.

The original commit 7521e0cf9e88 ("ofproto-dpif: Let the dpif report
when a port is a duplicate.") relies on the kernel to check if the
port exists or not. However, the current kernel code doesn't handle
when the port is moved to another network namespace.

Signed-off-by: Flavio Leitner <fbl at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 7ec2870807420c6ea00de2fec9f327df7b63e471
      https://github.com/openvswitch/ovs/commit/7ec2870807420c6ea00de2fec9f327df7b63e471
  Author: Flavio Leitner <fbl at redhat.com>
  Date:   2019-01-25 (Fri, 25 Jan 2019)

  Changed paths:
    M ofproto/ofproto-dpif.c

  Log Message:
  -----------
  Revert "ofproto-dpif: Check for EBUSY as well"

This reverts commit c65259a9b6e5380ac963944b69949ceb71ae623a.

The original commit 7521e0cf9e88 ("ofproto-dpif: Let the dpif report
when a port is a duplicate.") relies on the kernel to check if the
port exists or not. However, the current kernel code doesn't handle
when the port is moved to another network namespace.

Signed-off-by: Flavio Leitner <fbl at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: d4ff5b2be7fc06b6dafffe424ccc3ed3610876f2
      https://github.com/openvswitch/ovs/commit/d4ff5b2be7fc06b6dafffe424ccc3ed3610876f2
  Author: Flavio Leitner <fbl at redhat.com>
  Date:   2019-01-25 (Fri, 25 Jan 2019)

  Changed paths:
    M lib/dpif.c
    M ofproto/ofproto-dpif.c

  Log Message:
  -----------
  Revert "ofproto-dpif: Let the dpif report when a port is a duplicate."

This reverts commit 7521e0cf9e88a62f2feff4e7253654557f94877e.

This patch introduced a regression in OSP environments using internal
ports in other netns. Their networking configuration is lost when
the service is restarted because the ports are recreated now.

Before the patch it checked using netlink if the port with a specific
"name" was already there. The check is a lookup in all ports attached
to the DP regardless of the port's netns.

After the patch it relies on the kernel to identify that situation.
Unfortunately the only protection there is register_netdevice() which
fails only if the port with that name exists in the current netns.

If the port is in another netns, it will get a new dp_port and because
of that userspace will delete the old port. At this point the original
port is gone from the other netns and there a fresh port in the current
netns.

Signed-off-by: Flavio Leitner <fbl at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/6dfa5b6c2fbd...d4ff5b2be7fc
      **NOTE:** GitHub Services has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      We will provide an alternative path for the email notifications by January 31st, 2019.


More information about the git mailing list