[ovs-git] [openvswitch/ovs] 38dcfb: Revert "dpif-netlink: Don't destroy and recreate p...

[GitHub]

  Branch: refs/heads/branch-2.10
  Home:   https://github.com/openvswitch/ovs
  Commit: 38dcfb71abc7688f48853649f6e19317811752e8
      https://github.com/openvswitch/ovs/commit/38dcfb71abc7688f48853649f6e19317811752e8
  Author: Flavio Leitner <fbl at redhat.com>
  Date:   2019-01-25 (Fri, 25 Jan 2019)

  Changed paths:
    M lib/dpif-netlink.c

  Log Message:
  -----------
  Revert "dpif-netlink: Don't destroy and recreate port if it exists"

This reverts commit  a38dccb3ee80a1d0b8973191c9e94f045441f8cc.

The original commit 7521e0cf9e88 ("ofproto-dpif: Let the dpif report
when a port is a duplicate.") relies on the kernel to check if the
port exists or not. However, the current kernel code doesn't handle
when the port is moved to another network namespace.

Signed-off-by: Flavio Leitner <fbl at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 29c17d77b873ed7149c134c566da11efd9fdabfc
      https://github.com/openvswitch/ovs/commit/29c17d77b873ed7149c134c566da11efd9fdabfc
  Author: Flavio Leitner <fbl at redhat.com>
  Date:   2019-01-25 (Fri, 25 Jan 2019)

  Changed paths:
    M ofproto/ofproto-dpif.c

  Log Message:
  -----------
  Revert "ofproto-dpif: Check for EBUSY as well"

This reverts commit c65259a9b6e5380ac963944b69949ceb71ae623a.

The original commit 7521e0cf9e88 ("ofproto-dpif: Let the dpif report
when a port is a duplicate.") relies on the kernel to check if the
port exists or not. However, the current kernel code doesn't handle
when the port is moved to another network namespace.

Signed-off-by: Flavio Leitner <fbl at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: f9f353a50fa2f9e6ea7a210f9f0ebe7b154f3bf6
      https://github.com/openvswitch/ovs/commit/f9f353a50fa2f9e6ea7a210f9f0ebe7b154f3bf6
  Author: Flavio Leitner <fbl at redhat.com>
  Date:   2019-01-25 (Fri, 25 Jan 2019)

  Changed paths:
    M lib/dpif.c
    M ofproto/ofproto-dpif.c

  Log Message:
  -----------
  Revert "ofproto-dpif: Let the dpif report when a port is a duplicate."

This reverts commit 7521e0cf9e88a62f2feff4e7253654557f94877e.

This patch introduced a regression in OSP environments using internal
ports in other netns. Their networking configuration is lost when
the service is restarted because the ports are recreated now.

Before the patch it checked using netlink if the port with a specific
"name" was already there. The check is a lookup in all ports attached
to the DP regardless of the port's netns.

After the patch it relies on the kernel to identify that situation.
Unfortunately the only protection there is register_netdevice() which
fails only if the port with that name exists in the current netns.

If the port is in another netns, it will get a new dp_port and because
of that userspace will delete the old port. At this point the original
port is gone from the other netns and there a fresh port in the current
netns.

Signed-off-by: Flavio Leitner <fbl at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/55e361b42e74...f9f353a50fa2
      **NOTE:** GitHub Services has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      We will provide an alternative path for the email notifications by January 31st, 2019.