[ovs-git] [openvswitch/ovs] 998bfd: ossfuzz: Remove duplicate tcp flags parsing in flo...

Bhargava Shastry noreply at github.com
Wed Jul 3 18:09:53 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 998bfdccf5c39630446b37449205ecc43894585f
      https://github.com/openvswitch/ovs/commit/998bfdccf5c39630446b37449205ecc43894585f
  Author: Bhargava Shastry <bshas3 at gmail.com>
  Date:   2019-07-03 (Wed, 03 Jul 2019)

  Changed paths:
    M tests/oss-fuzz/flow_extract_target.c

  Log Message:
  -----------
  ossfuzz: Remove duplicate tcp flags parsing in flow extract target

During a code audit, the flow extraction fuzzer target was seen to be
 parsing tcp flags from the fuzzer supplied input twice. This is
probably a typo since the second call to `parse_tcp_flags()` is
identical to the first.
Since a call to `parse_tcp_flags()` parses the Ethernet and IP headers
contained in the packet, the second (buggy) call to `parse_tcp_flags()`
creates an expectation that there is a second set of Ethernet and IP
headers beyond the first which is incorrect. This patch fixes this
problem by removing the duplicate code in question.

Signed-off-by: Bhargava Shastry <bshas3 at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>




More information about the git mailing list