[ovs-git] [openvswitch/ovs] 4e6c16: doc: Move vhost tx retry info to separate section.

kevintraynor noreply at github.com
Mon Jul 8 12:43:21 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 4e6c16db31806dfcf84d6ebdb0d708cfa39bd08f
      https://github.com/openvswitch/ovs/commit/4e6c16db31806dfcf84d6ebdb0d708cfa39bd08f
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M Documentation/topics/dpdk/vhost-user.rst

  Log Message:
  -----------
  doc: Move vhost tx retry info to separate section.

vhost tx retry is applicable to vhost-user and vhost-user-client,
but was in the section that compares them. Also, moved further
down the doc as prefer to have more fundamental info about vhost
nearer the top.

Fixes: 6d6513bfc657 ("doc: Add info on vhost tx retries.")
Reported-by: David Marchand <david.marchand at redhat.com>
Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: c161357d5d96f32144f4b63ee6b06049c0cc0a09
      https://github.com/openvswitch/ovs/commit/c161357d5d96f32144f4b63ee6b06049c0cc0a09
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M Documentation/topics/dpdk/vhost-user.rst
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Add custom stat for vhost tx retries.

vhost tx retries may occur, and it can be a sign that
the guest is not optimally configured.

Add a custom stat so a user will know if vhost tx retries are
occurring and hence give a hint that guest config should be
examined.

Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


  Commit: 080f080c3bc1e87da4affdce28a01b1a87a60364
      https://github.com/openvswitch/ovs/commit/080f080c3bc1e87da4affdce28a01b1a87a60364
  Author: Kevin Traynor <ktraynor at redhat.com>
  Date:   2019-07-08 (Mon, 08 Jul 2019)

  Changed paths:
    M Documentation/topics/dpdk/vhost-user.rst
    M NEWS
    M lib/netdev-dpdk.c
    M vswitchd/vswitch.xml

  Log Message:
  -----------
  netdev-dpdk: Enable tx-retries-max config.

vhost tx retries can provide some mitigation against
dropped packets due to a temporarily slow guest/limited queue
size for an interface, but on the other hand when a system
is fully loaded those extra cycles retrying could mean
packets are dropped elsewhere.

Up to now max vhost tx retries have been hardcoded, which meant
no tuning and no way to disable for debugging to see if extra
cycles spent retrying resulted in rx drops on some other
interface.

Add an option to change the max retries, with a value of
0 effectively disabling vhost tx retries.

Signed-off-by: Kevin Traynor <ktraynor at redhat.com>
Acked-by: Eelco Chaudron <echaudro at redhat.com>
Acked-by: Flavio Leitner <fbl at sysclose.org>
Acked-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>


Compare: https://github.com/openvswitch/ovs/compare/f26196e316f2...080f080c3bc1


More information about the git mailing list