[ovs-git] [openvswitch/ovs] 5f918a: conntrack: Don't re-add cleaned 'conn' to expiry l...

Ben Pfaff noreply at github.com
Wed Jun 5 22:07:05 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 5f918a8a4d4a775b9c1239657afcd73af3ec9827
      https://github.com/openvswitch/ovs/commit/5f918a8a4d4a775b9c1239657afcd73af3ec9827
  Author: Darrell Ball <dlu998 at gmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M lib/conntrack-private.h
    M lib/conntrack.c

  Log Message:
  -----------
  conntrack: Don't re-add cleaned 'conn' to expiry list.

When a 'conn' entry is cleaned up from an expiry list, we don't
want to put it back during an update.  Hence, we detect and block this.

Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
Signed-off-by: Darrell Ball <dlu998 at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 28274f774adb3f85a7b351ba24ab0ba7817c9794
      https://github.com/openvswitch/ovs/commit/28274f774adb3f85a7b351ba24ab0ba7817c9794
  Author: Darrell Ball <dlu998 at gmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M lib/conntrack.c

  Log Message:
  -----------
  conntrack: Fix missed 'conn' lookup checks.

Whenever a 'conn' entry is removed or added, we need to reverify it's
existence status under lock protection.  There were some cases that
were missed, so fix them.

Fixes: 967bb5c5cd90 ("conntrack: Add rcu support.")
Signed-off-by: Darrell Ball <dlu998 at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


  Commit: 4048c5088f95f336a7311eb484e80af6764ff71c
      https://github.com/openvswitch/ovs/commit/4048c5088f95f336a7311eb484e80af6764ff71c
  Author: Darrell Ball <dlu998 at gmail.com>
  Date:   2019-06-05 (Wed, 05 Jun 2019)

  Changed paths:
    M lib/conntrack.c

  Log Message:
  -----------
  conntrack: Add 'conn_lookup()' api.

The new api incorporates the hash calculation which can be a
distraction.

Signed-off-by: Darrell Ball <dlu998 at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/52d12cc4590d...4048c5088f95


More information about the git mailing list