[ovs-git] [openvswitch/ovs] a66b2f: dpif-netdev: Fix flow mark leak on port lookup fai...

Ilya Maximets noreply at github.com
Thu Jun 6 15:54:06 UTC 2019


  Branch: refs/heads/branch-2.10
  Home:   https://github.com/openvswitch/ovs
  Commit: a66b2f7f8f329e6f2c2ac4649291703794f8a5b5
      https://github.com/openvswitch/ovs/commit/a66b2f7f8f329e6f2c2ac4649291703794f8a5b5
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-06-06 (Thu, 06 Jun 2019)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Fix flow mark leak on port lookup failure.

Flow mark should be properly freed in all error cases.

Fixes: 241bad15d99a ("dpif-netdev: associate flow with a mark id")
Acked-By: Roni Bar Yanai <roniba at mellanox.com>
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>


  Commit: f586112b753e1dc9e9ed49a44d1582628f600191
      https://github.com/openvswitch/ovs/commit/f586112b753e1dc9e9ed49a44d1582628f600191
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-06-06 (Thu, 06 Jun 2019)

  Changed paths:
    M lib/dpif-netdev.c

  Log Message:
  -----------
  dpif-netdev: Forbid vport offloading attempts.

'netdev_flow_put()' for vports could eventually succeed for
userspace datapath in case there is a kernel datapath with
similar vport at the same time. The root cause is that vports
like 'vxlan' uses same 'vxlan_sys_<port>' system interfaces
for flow offloading and there is no way to distinguish system
and userspace vports using only 'netdev' structure.

Let's forbid vport offloading from userspace datapath to avoid
installing userspace flows to unrelated system devices.

Future dynamic flow API management will allow to enable vport
offloading back using more flexible checks.

Fixes: 241bad15d99a ("dpif-netdev: associate flow with a mark id")
Reported-by: Ophir Munk <ophirmu at mellanox.com>
Acked-By: Roni Bar Yanai <roniba at mellanox.com>
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>


Compare: https://github.com/openvswitch/ovs/compare/3a8161576700...f586112b753e


More information about the git mailing list