[ovs-git] [openvswitch/ovs] db7a3c: ovn-controller: Fix parsing of OVN tunnel IDs

[Dumitru Ceara]

  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: db7a3c99e899ccb68c39e17fba5bc06632ebcfec
      https://github.com/openvswitch/ovs/commit/db7a3c99e899ccb68c39e17fba5bc06632ebcfec
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2019-06-12 (Wed, 12 Jun 2019)

  Changed paths:
    M ovn/controller/bfd.c
    M ovn/controller/encaps.c
    M ovn/controller/encaps.h
    M ovn/controller/ovn-controller.h
    M ovn/controller/physical.c
    M ovn/controller/pinctrl.c

  Log Message:
  -----------
  ovn-controller: Fix parsing of OVN tunnel IDs

Encap tunnel-ids are of the form:
<chassis-id><OVN_MVTEP_CHASSISID_DELIM><encap-ip>.
In physical_run we were checking if a tunnel-id corresponds
to the local chassis-id by searching if the chassis-id string
is included in the tunnel-id (strstr). This can break quite
easily, for example, if the local chassis-id is a substring
of a remote chassis-id. In that case we were wrongfully
skipping the tunnel creation.

To fix that new tunnel-id creation and parsing functions are added in
encaps.[ch]. These functions are now used everywhere where applicable.

Acked-by: Venu Iyer <iyervl at ymail.com>
Reported-at: https://bugzilla.redhat.com/1708131
Reported-by: Haidong Li <haili at redhat.com>
Fixes: b520ca7 ("Support for multiple VTEP in OVN")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>