[ovs-git] [openvswitch/ovs] 6f5901: dpdk: Fix case-sensitivity of dpdk-init knob.

istokes noreply at github.com
Fri Mar 1 13:25:33 UTC 2019


  Branch: refs/heads/branch-2.11
  Home:   https://github.com/openvswitch/ovs
  Commit: 6f5901c2efaa0819a9d4d5996235ea89d1286626
      https://github.com/openvswitch/ovs/commit/6f5901c2efaa0819a9d4d5996235ea89d1286626
  Author: Ilya Maximets <i.maximets at samsung.com>
  Date:   2019-03-01 (Fri, 01 Mar 2019)

  Changed paths:
    M lib/dpdk.c

  Log Message:
  -----------
  dpdk: Fix case-sensitivity of dpdk-init knob.

Before supporting the DPDK initialization status in DB 'dpdk-init' was
just a boolean and 'smap_get_bool', which is case-insensitive, was used
to get the value.

Current code uses simple 'strcmp' that fails to recognize values like
"True". As a result this breaks different OVS configuration tools.
For example, kolla-ansible uses 'other_config:dpdk-init=True' but OVS
is not able to recognize it leading to broken installations.

'strcasecmp' should be used instead to fix the issue.

CC: Aaron Conole <aconole at redhat.com>
Fixes: 3e52fa5644cd ("dpdk: reflect status and version in the database")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>




More information about the git mailing list