[ovs-git] [openvswitch/ovs] 9c60fd: datapath-windows: Fix nbl cleanup when memory allo...

Alin Gabriel Serdean noreply at github.com
Wed Mar 13 11:20:25 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 9c60fd48790afac901696c07b2befef3d2ea6301
      https://github.com/openvswitch/ovs/commit/9c60fd48790afac901696c07b2befef3d2ea6301
  Author: Sairam Venugopal <vsairam at vmware.com>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M datapath-windows/ovsext/PacketIO.c

  Log Message:
  -----------
  datapath-windows: Fix nbl cleanup when memory allocation fails

StartNblIngressError should be called only when an NBL hasn't been
modified. In this case the nbl context was initialized. Rely on existing
packet completion mechanism to cleanup the NBL.

Found while testing with DriverVerifier with limited memory setting
enabled.

Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Anand Kumar <kumaranand at vmware.com>
Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>


  Commit: 132733d4b064191e917ea98ca4bf165f8cca2071
      https://github.com/openvswitch/ovs/commit/132733d4b064191e917ea98ca4bf165f8cca2071
  Author: Sairam Venugopal <vsairam at vmware.com>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M datapath-windows/ovsext/Event.c

  Log Message:
  -----------
  datapath-windows: Fix potential deadlock in event subscription

Move the EventQueue lock acquisition after the dispatchLock to prevent a
potential deadlock in port creation pipeline. There could be a case where
a port event could try to take up the Dispatch Lock before the Event Queue
lock and the subscription queue event could take up the event queue lock
before the dispatch lock.

Found while testing with Driver Verifier enabled.

Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at ovn.org>
Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>


  Commit: adffc2f75ec41473fe6c96f69aed2385b642cc20
      https://github.com/openvswitch/ovs/commit/adffc2f75ec41473fe6c96f69aed2385b642cc20
  Author: Sairam Venugopal <vsairam at vmware.com>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M datapath-windows/ovsext/Vport.c

  Log Message:
  -----------
  datapath-windows: Fix race condition during port creation

Hold the dispatch lock until port-add operations are completed.

Found by inspection.

Signed-off-by: Sairam Venugopal <vsairam at vmware.com>
Acked-by: Alin Gabriel Serdean <aserdean at ovn.org>
Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>


  Commit: 07f6b71daada1e1d5966abccd61b04820190195a
      https://github.com/openvswitch/ovs/commit/07f6b71daada1e1d5966abccd61b04820190195a
  Author: Anand Kumar <kumaranand at vmware.com>
  Date:   2019-03-13 (Wed, 13 Mar 2019)

  Changed paths:
    M Documentation/faq/releases.rst

  Log Message:
  -----------
  faq: Update features supported on Hyper-V

These features were added a while back, so updating
the documentation.

Signed-off-by: Anand Kumar <kumaranand at vmware.com>
Acked-by: Sairam Venugopal <vsairam at vmware.com>
Signed-off-by: Alin Gabriel Serdean <aserdean at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/a47e2db209e4...07f6b71daada


More information about the git mailing list