[ovs-git] [openvswitch/ovs] 44e429: netdev-tc-offloads: Properly get the block id on f...

Simon Horman noreply at github.com
Mon Mar 18 15:46:24 UTC 2019


  Branch: refs/heads/branch-2.10
  Home:   https://github.com/openvswitch/ovs
  Commit: 44e429a55b55df7cf685d2a17499aa6d441966b4
      https://github.com/openvswitch/ovs/commit/44e429a55b55df7cf685d2a17499aa6d441966b4
  Author: Or Gerlitz <ogerlitz at mellanox.com>
  Date:   2019-03-18 (Mon, 18 Mar 2019)

  Changed paths:
    M lib/netdev-tc-offloads.c

  Log Message:
  -----------
  netdev-tc-offloads: Properly get the block id on flow del/get

Currnetly, when a tc flow is installed on a bond port using shared blocks,
we get these failures from the validator threads:

2019-03-17T10:02:58.919Z|13369|dpif(revalidator93)|WARN|system at ovs-system: failed to flow_del \
	(No such file or directory) ufid:ebe2888b-9886-4835-a42e-c2911f6af6e8 skb_priority(0),skb_mark(0),in_port(2), \
	packet_type(ns=0,id=0),eth(src=e4:11:22:33:44:71,dst=24:8a:07:88:28:12),eth_type(0x0806), [..]

The block id must be retrieved from the device we got by ufid lookup and
not from the input to the related function, fix that for flow del and get.

While here, add the block id to existing debug print.

Fixes: 88dcf2aa8234 ('netdev-provider: add class op to get block_id')
Signed-off-by: Or Gerlitz <ogerlitz at mellanox.com>
Signed-off-by: Paul Blakey <paulb at mellanox.com>
Reviewed-by: Roi Dayan <roid at mellanox.com>
Signed-off-by: Simon Horman <simon.horman at netronome.com>




More information about the git mailing list