[ovs-git] [openvswitch/ovs] 2e97b8: dpif-netdev-perf: Fix double update of perf histog...
istokes
noreply at github.com
Tue Mar 19 10:56:16 UTC 2019
Branch: refs/heads/master
Home: https://github.com/openvswitch/ovs
Commit: 2e97b8419c6e5285649f955a5f5a4f7c2875c877
https://github.com/openvswitch/ovs/commit/2e97b8419c6e5285649f955a5f5a4f7c2875c877
Author: Ilya Maximets <i.maximets at samsung.com>
Date: 2019-03-19 (Tue, 19 Mar 2019)
Changed paths:
M lib/dpif-netdev-perf.c
Log Message:
-----------
dpif-netdev-perf: Fix double update of perf histograms.
Real values of 'packets per batch' and 'cycles per upcall' already
added to histograms in 'dpif-netdev' on receive. Adding the averages
makes statistics wrong. We should not add to histograms values that
never really appeared.
For exmaple, in current code following situation is possible:
pmd thread numa_id 0 core_id 5:
...
Rx packets: 83 (0 Kpps, 13873 cycles/pkt)
...
- Upcalls: 3 ( 3.6 %, 248.6 us/upcall)
Histograms
packets/it pkts/batch upcalls/it cycles/upcall
1 83 1 166 1 3 ...
15848 2
19952 2
...
50118 2
i.e. all the packets counted twice in 'pkts/batch' column and
all the upcalls counted twice in 'cycles/upcall' column.
CC: Jan Scheurich <jan.scheurich at ericsson.com>
Fixes: 79f368756ce8 ("dpif-netdev: Detailed performance stats for PMDs")
Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
Signed-off-by: Ian Stokes <ian.stokes at intel.com>
More information about the git
mailing list