[ovs-git] [openvswitch/ovs] 402484: ofp-group: support to insert bucket with weight va...

Simon Horman noreply at github.com
Wed Mar 27 10:50:38 UTC 2019


  Branch: refs/heads/branch-2.8
  Home:   https://github.com/openvswitch/ovs
  Commit: 402484cc1dd4b1bba624bb2c6fcc6d152f2248eb
      https://github.com/openvswitch/ovs/commit/402484cc1dd4b1bba624bb2c6fcc6d152f2248eb
  Author: solomon <liwei.solomon at gmail.com>
  Date:   2019-03-27 (Wed, 27 Mar 2019)

  Changed paths:
    M lib/ofp-parse.c
    M lib/ofp-util.c
    M tests/ofproto.at

  Log Message:
  -----------
  ofp-group: support to insert bucket with weight value for select type

After creating a group with hash select type,then  we need to insert a new
bucket with weight, But,it fails. Commands are as following:

   # ovs-ofctl  -O OpenFlow15 add-group br0 "group_id=10, type=select, selection_method=hash,fields=tcp_src, bucket=bucket_id=10,weight:99,actions=output:1, bucket=bucket_id=20,weight:199,actions=output:1 "

   # ovs-ofctl -O OpenFlow15 insert-buckets br0 "group_id=10,type=select command_bucket_id=last,bucket=bucket_id=3,weight=100,actions=output:1"
   ovs-ofctl: type is not needed

   # ovs-ofctl -O OpenFlow15 insert-buckets br0 "group_id=10 command_bucket_id=last,bucket=bucket_id=3,weight=100,actions=output:1"
   ovs-ofctl: Only select groups can have bucket weights.

This patch can help us. However, for other types that are not select, the
check of the parameters is not strict, but it does not affect their
function, because other types do not use this weight parameter.

Signed-off-by: solomon <liwei.solomon at gmail.com>
Signed-off-by: Ben Pfaff <blp at ovn.org>
[simon: rebased]
Signed-off-by: Simon Horman <simon.horman at netronome.com>




More information about the git mailing list