[ovs-git] [openvswitch/ovs] 0c489c: tests: Wait up to OVS_CTL_TIMEOUT seconds.

Ilya Maximets noreply at github.com
Wed Nov 6 23:34:48 UTC 2019


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 0c489cc54a6cac72daea2314cc6464f629356c50
      https://github.com/openvswitch/ovs/commit/0c489cc54a6cac72daea2314cc6464f629356c50
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2019-11-06 (Wed, 06 Nov 2019)

  Changed paths:
    M tests/ovs-macros.at

  Log Message:
  -----------
  tests: Wait up to OVS_CTL_TIMEOUT seconds.

While running tests under valgrind, it could take more than 10 seconds
for process to disappear after successful 'ovs-appctl exit' command.

Same applies to some other events that tests are waiting for with
OVS_WAIT macro.  This makes tests to fail frequently under valgrind.

Using OVS_CTL_TIMEOUT variable instead of constant 10 seconds seems
reasonable to avoid this issue because it controls timeouts of all
control utilities and needs to be adjusted while running under valgrind
anyway.

Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
Acked-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: William Tu <u9012063 at gmail.com>




More information about the git mailing list